-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[watchOS] Text input list view controller is not legible when present…
…ed over a transparent background https://bugs.webkit.org/show_bug.cgi?id=270821 rdar://118537615 Reviewed by Abrar Rahman Protyasha and Tim Horton. Explicitly set the input view controllers' views' background colors to be `+systemBackgroundColor`. Currently, these views are transparent, which works well in practice (since they present over a black background anyways), but for certain clients that use a transparent background, this can cause system UI to show up from behind the input view controllers. * Source/WebKit/Platform/spi/watchos/PepperUICoreSPI.h: Drive-by fix: remove some dead code, now that `-listView` is no longer implemented by the base class when presenting a single or multi-select menu. Instead, reloading the `-collectionView` is sufficient. * Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm: (-[WKDatePickerViewController viewDidLoad]): * Source/WebKit/UIProcess/ios/forms/WKNumberPadViewController.mm: (-[WKNumberPadViewController viewDidLoad]): * Source/WebKit/UIProcess/ios/forms/WKSelectMenuListViewController.mm: (-[WKSelectMenuListViewController viewDidLoad]): (-[WKSelectMenuListViewController didSelectListItemAtIndexPath:]): (-[WKSelectMenuListViewController cellForListItem:]): Deleted. * Source/WebKit/UIProcess/ios/forms/WKTextInputListViewController.mm: (-[WKTextInputListViewController viewDidLoad]): * Source/WebKit/UIProcess/ios/forms/WKTimePickerViewController.mm: (-[WKTimePickerViewController viewDidLoad]): Canonical link: https://commits.webkit.org/275947@main
- Loading branch information
Showing
6 changed files
with
15 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters