Skip to content

Commit

Permalink
[WebGPU] Queue::writeTexture may write outside its temporary buffer
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=274171
<radar://128064885>

Reviewed by Dan Glastonbury.

bytesPerImage must be a multiple of the blockHeight, but the division
was occurring outside the max() operation instead of inside the right
hand side.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-274171-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-274171.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::writeTexture):

Canonical link: https://commits.webkit.org/279027@main
  • Loading branch information
mwyrzykowski committed May 21, 2024
1 parent 4349cc0 commit 33e3b62
Show file tree
Hide file tree
Showing 4 changed files with 23,568 additions and 1 deletion.
2 changes: 2 additions & 0 deletions LayoutTests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -2131,6 +2131,8 @@ webkit.org/b/139639 [ Debug ] cssom/non-subpixel-scroll-top-left-values.html [ S
[ Release ] fast/webgpu/fuzz-274334.html [ Pass Failure Timeout ]
[ Debug ] fast/webgpu/fuzz-274289.html [ Skip ]
[ Release ] fast/webgpu/fuzz-274289.html [ Pass Failure Timeout ]
[ Debug ] fast/webgpu/fuzz-274171.html [ Skip ]
[ Release ] fast/webgpu/fuzz-274171.html [ Pass Failure Timeout ]

# Imported W3C HTML/DOM ref tests that are failing.
imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-N-between-Rs.html [ ImageOnlyFailure ]
Expand Down
Loading

0 comments on commit 33e3b62

Please sign in to comment.