[Win] REGRESSION(272822@main): StreamClientConnection.h(216,20): erro…

…r: call to implicitly-deleted copy constructor of 'StreamClientConnection::SendSyncResult<PrepareForDisplay>'

https://bugs.webkit.org/show_bug.cgi?id=267294
rdar://120756511

Reviewed by Alex Christensen.

Fujii suggested this fix, and I initially thought I could do better by modifying WTF::Expected,
but after looking at it for a few hours, I'm not sure why MSVC doesn't see the move constructor.
Soon we'll have std::expected and this will hopefully not be an issue.

Also move a NO_RETURN_DUE_TO_CRASH macro to make MSVC happy.

* Source/WTF/wtf/Expected.h:
(std::experimental::fundamentals_v3::__expected_detail::constexpr_base::constexpr_base):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::terminateWebContentProcess):
* Source/WebCore/testing/Internals.h:

Canonical link: https://commits.webkit.org/272842@main

Source/WebCore/testing/Internals.cpp

@@ -6184,7 +6184,7 @@ void Internals::whenServiceWorkerIsTerminated(ServiceWorker& worker, DOMPromiseD
     });
 }
 
-NO_RETURN_DUE_TO_CRASH void Internals::terminateWebContentProcess()
+void Internals::terminateWebContentProcess()
 {
     exit(0);
 }

Source/WebCore/testing/Internals.h

@@ -1016,7 +1016,7 @@ class Internals final : public RefCounted<Internals>, private ContextDestruction
     void hasServiceWorkerRegistration(const String& clientURL, HasRegistrationPromise&&);
     void terminateServiceWorker(ServiceWorker&, DOMPromiseDeferred<void>&&);
     void whenServiceWorkerIsTerminated(ServiceWorker&, DOMPromiseDeferred<void>&&);
-    void terminateWebContentProcess();
+    NO_RETURN_DUE_TO_CRASH void terminateWebContentProcess();
 
 #if ENABLE(APPLE_PAY)
     MockPaymentCoordinator& mockPaymentCoordinator(Document&);

Source/WebKit/Platform/IPC/Connection.h

@@ -169,6 +169,15 @@ template<typename T> struct ConnectionSendSyncResult {
     bool succeeded() const { return value.has_value(); }
     Error error() const { return value.has_value() ? Error::NoError : value.error(); }
 
+    // FIXME: Remove this when we start using c++23 and std::expected.
+#if OS(WINDOWS) // Expected isn't move-constuctible
+    ConnectionSendSyncResult(ConnectionSendSyncResult&& other)
+        : value(makeUnexpected(Error::NoError))
+    {
+        value.swap(other.value);
+    }
+#endif
+
     typename T::ReplyArguments& reply()
     {
         return value.value();