-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
AX: Fix to handle author error roles
https://bugs.webkit.org/show_bug.cgi?id=261542 rdar://problem/115462091 Reviewed by Tyler Wilcock. This commit fixes the wai-aria/role/form-roles test[1]. According to the ARIA spec[2], in situations where an author has not specified names for the form and region landmarks, it is considered as authoring error. If a valid fallback role had been specified, or if the element had an implicit ARIA role, then user agents would continue to expose that role instead. [1]: https://wpt.fyi/results/wai-aria/role/form-roles.html [2]: https://w3c.github.io/aria/#document-handling_author-errors_roles * LayoutTests/accessibility/aria-namefrom-author.html: * LayoutTests/accessibility/roles-computedRoleString.html: * LayoutTests/imported/w3c/web-platform-tests/wai-aria/role/form-roles-expected.txt: * LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt: * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::determineAriaRoleAttribute const): Canonical link: https://commits.webkit.org/268025@main
- Loading branch information
Showing
5 changed files
with
41 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters