Account for identity in UserMediaCaptureManagerProxy::startProducingD…

…ata for camera

https://bugs.webkit.org/show_bug.cgi?id=270995
rdar://124631514

Reviewed by Eric Carlson.

When media environment is not available, we can still rely on identity safely.
The camera check is only accounting for media environment so we update it to check for identity as well,
so that it does not unnecessarily fail capture.

* Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h:
* Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::startProducingData):

Canonical link: https://commits.webkit.org/276147@main

Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h

@@ -105,6 +105,7 @@ class WEBCORE_EXPORT RealtimeMediaSourceCenter : public ThreadSafeRefCounted<Rea
 #if ENABLE(APP_PRIVACY_REPORT)
     void setIdentity(OSObjectPtr<tcc_identity_t>&& identity) { m_identity = WTFMove(identity); }
     OSObjectPtr<tcc_identity_t> identity() const { return m_identity; }
+    bool hasIdentity() const { return !!m_identity; }
 #endif
 
 #if ENABLE(EXTENSION_CAPABILITIES)

Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp

@@ -572,8 +572,8 @@ void UserMediaCaptureManagerProxy::startProducingData(RealtimeMediaSourceIdentif
     m_connectionProxy->setTCCIdentity();
 #endif
 #if ENABLE(EXTENSION_CAPABILITIES)
-    bool hasValidMediaEnvironment = m_connectionProxy->setCurrentMediaEnvironment(pageIdentifier);
-    if (!hasValidMediaEnvironment && proxy->source().deviceType() == CaptureDevice::DeviceType::Camera && WTF::processHasEntitlement("com.apple.developer.web-browser-engine.rendering"_s)) {
+    bool hasValidMediaEnvironmentOrIdentity = m_connectionProxy->setCurrentMediaEnvironment(pageIdentifier) || RealtimeMediaSourceCenter::singleton().hasIdentity();
+    if (!hasValidMediaEnvironmentOrIdentity && proxy->source().deviceType() == CaptureDevice::DeviceType::Camera && WTF::processHasEntitlement("com.apple.developer.web-browser-engine.rendering"_s)) {
         RELEASE_LOG_ERROR(WebRTC, "Unable to set media environment, failing capture.");
         proxy->source().captureFailed();
         return;