Skip to content
Permalink
Browse files
2010-04-11 Joseph Pecoraro <joepeck@webkit.org>
        Reviewed by Eric Seidel.

        Minor Updates and Cleanup to the Contributing Page
        https://bugs.webkit.org/show_bug.cgi?id=37415

        * coding/contributing.html:

Canonical link: https://commits.webkit.org/48741@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@57452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
eseidel committed Apr 11, 2010
1 parent 681134e commit 48e9240e5b181288e9ee638eb6e8f46a53ce817a
Showing 2 changed files with 11 additions and 2 deletions.
@@ -1,3 +1,12 @@
2010-04-11 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Eric Seidel.

Minor Updates and Cleanup to the Contributing Page
https://bugs.webkit.org/show_bug.cgi?id=37415

* coding/contributing.html:

2010-04-07 Maciej Stachowiak <mjs@apple.com>

(Not reviewed.)
@@ -120,7 +120,7 @@ <h3 id="changelogs">ChangeLog files</h3>

<p>There is one ChangeLog per top-level directory, if you changed code and tests you will need to edit at least two ChangeLogs. The <code>prepare-ChangeLog</code> script will create a stub entries for you. You should edit these stubs to describe your change, including the full url to the bug (<a href="http://trac.webkit.org/changeset/43259">example entry</a>, note that you can use <code>--bug</code> flag). (You should set EMAIL_ADDRESS and CHANGE_LOG_NAME in your environment if you will be running this script frequently.)</p>

<p>The line WARNING: NO TEST CASES ADDED OR CHANGED appears if prepare-ChangeLog did not detect the addition of test cases. If your patch does not require test cases (or test cases are not possible), you should include a line stating such. Otherwise all changes require test cases which should be mentioned in the ChangeLog.</p>
<p>The "No new tests. (OOPS!)" line appears if <code>prepare-ChangeLog</code> did not detect the addition of test cases. If your patch does not require test cases (or test cases are not possible), you should include a line stating such. Otherwise all changes require test cases which should be mentioned in the ChangeLog.</p>

<h3>Create the patch</h3>
<p>WebKit uses <code>svn-create-patch</code> to create patches. The
@@ -131,7 +131,7 @@ <h3>Create the patch</h3>
break a patch into multiple files.</p>

<p>The <code>svn-create-patch</code> script does not create a file automatically.
You need to redirect the output yourself using something like--</p>
You need to redirect the output yourself using something like:</p>
<p class="code">svn-create-patch > MyExcellentPatch.txt</p>

<h3 id="submit">Submit your patch</h3>

0 comments on commit 48e9240

Please sign in to comment.