Skip to content

Commit

Permalink
REGRESSION (276513@main): [ iOS ] fast/images/async-image-intersect-d…
Browse files Browse the repository at this point in the history
…ifferent-size-for-drawing.html is a consistent failure

https://bugs.webkit.org/show_bug.cgi?id=271669
rdar://125372071

Unreviewed test gardening.

Since WKTR run in 2x on iOS simulator, we need to add a platform iOS expected
results for this test.

* LayoutTests/fast/images/async-image-intersect-different-size-for-drawing-expected.txt:
* LayoutTests/fast/images/async-image-intersect-different-size-for-drawing.html:
* LayoutTests/platform/ios-wk2/TestExpectations:
* LayoutTests/platform/ios-wk2/fast/images/async-image-intersect-different-size-for-drawing-expected.txt: Added.

Canonical link: https://commits.webkit.org/276703@main
  • Loading branch information
shallawa authored and Said Abou-Hallawa committed Mar 26, 2024
1 parent 616a4f9 commit 4a2e659
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ Ensures a renderer will decode its image synchronously if it intersects with ano
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


PASS decodingOptions is "{ decodingMode : Asynchronous, sizeForDrawing : { 500, 500 } }"
PASS decodingOptions is "{ decodingMode : Synchronous, sizeForDrawing : { 1000, 1000 } }"
decodingOptions = { decodingMode : Asynchronous, sizeForDrawing : { 500, 500 } }
decodingOptions = { decodingMode : Synchronous, sizeForDrawing : { 1000, 1000 } }
PASS successfullyParsed is true

TEST COMPLETE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,7 @@

loadImageAndDraw(intialBox, image1, "resources/green-400x400.png").then(() => {
requestAnimationFrame(() => {
decodingOptions = internals.imageLastDecodingOptions(image1);
shouldBeEqualToString("decodingOptions", "{ decodingMode : Asynchronous, sizeForDrawing : { 500, 500 } }");
debug("decodingOptions = " + internals.imageLastDecodingOptions(image1));

finalBox.appendChild(image1.cloneNode(true));
finalBox.style.display = "block";
Expand All @@ -94,8 +93,7 @@
testRunner.display();

requestAnimationFrame(() => {
decodingOptions = internals.imageLastDecodingOptions(image1);
shouldBeEqualToString("decodingOptions", "{ decodingMode : Synchronous, sizeForDrawing : { 1000, 1000 } }");
debug("decodingOptions = " + internals.imageLastDecodingOptions(image1));
finishJSTest();
});
});
Expand Down
2 changes: 0 additions & 2 deletions LayoutTests/platform/ios-wk2/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -2767,8 +2767,6 @@ imported/w3c/web-platform-tests/content-security-policy/script-src/script-src-re

webkit.org/b/271445 fast/events/ios/rotation/resize-iframe-after-orientation-change.html [ Pass Failure ]

webkit.org/b/271669 fast/images/async-image-intersect-different-size-for-drawing.html [ Failure ]

webkit.org/b/271678 imported/w3c/web-platform-tests/css/css-view-transitions/hit-test-unrelated-element.html [ ImageOnlyFailure ]

webkit.org/b/271682 imported/w3c/web-platform-tests/css/css-content/quotes-007.html [ ImageOnlyFailure ]
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
Ensures a renderer will decode its image synchronously if it intersects with another renderer with a different sizeForDrawing.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


decodingOptions = { decodingMode : Asynchronous, sizeForDrawing : { 1000, 1000 } }
decodingOptions = { decodingMode : Synchronous, sizeForDrawing : { 2000, 2000 } }
PASS successfullyParsed is true

TEST COMPLETE

0 comments on commit 4a2e659

Please sign in to comment.