-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[UnifiedPDF] Describe selection rects in terms of PDFPageCoverage
https://bugs.webkit.org/show_bug.cgi?id=274139 rdar://128043619 Reviewed by Abrar Rahman Protyasha. Replace `UnifiedPDFPlugin::boundsForSelection()` with `UnifiedPDFPlugin::pageCoverageForSelection()` which returns a `PDFPageCoverage`, which will be useful in future when we need to have per-page selection bounds info. `UnifiedPDFPlugin::textIndicatorForSelection()` can use this, asking for only the first page. `UnifiedPDFPlugin::selectionBoundsForFirstPageInDocumentSpace()` can be removed. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::pageCoverageForSelection const): (WebKit::UnifiedPDFPlugin::boundsForSelection const): (WebKit::UnifiedPDFPlugin::repaintOnSelectionActiveStateChangeIfNeeded): (WebKit::UnifiedPDFPlugin::setCurrentSelection): (WebKit::UnifiedPDFPlugin::textIndicatorForSelection): (WebKit::UnifiedPDFPlugin::selectionBoundsForFirstPageInDocumentSpace const): Deleted. Canonical link: https://commits.webkit.org/278759@main
- Loading branch information
Showing
2 changed files
with
39 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters