Skip to content

Commit

Permalink
[iOS] Avoid a spurious debug assertion after 271166@main
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=265471

Reviewed by Tim Horton.

Add an explicit case to handle the scenario where `UIKeyModifierFlags` is 0, to avoid hitting the
debug assertion below.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(shiftKeyState):

Canonical link: https://commits.webkit.org/271236@main
  • Loading branch information
whsieh committed Nov 28, 2023
1 parent 5954600 commit 61aa265
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Original file line number Diff line number Diff line change
Expand Up @@ -6959,6 +6959,7 @@ inline static UIShiftKeyState shiftKeyState(UIKeyModifierFlags flags)
return UIShiftKeyStateCapsLocked;
case UIKeyModifierShift:
return UIShiftKeyStateShifted;
case 0:
case UIKeyModifierControl:
case UIKeyModifierAlternate:
case UIKeyModifierCommand:
Expand Down

0 comments on commit 61aa265

Please sign in to comment.