-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[WebGPU] api,validation,error_scope,* is failing
https://bugs.webkit.org/show_bug.cgi?id=267287 <radar://120727304> Reviewed by Tadeu Zagallo. Add validation and passing expectations for api,validation,error_scope,* * LayoutTests/http/tests/webgpu/webgpu/api/validation/error_scope-expected.txt: * Source/WebCore/Modules/WebGPU/GPUAdapter.cpp: (WebCore::GPUAdapter::requestDevice): * Source/WebCore/Modules/WebGPU/GPUDevice.cpp: (WebCore::createGPUErrorFromWebGPUError): (WebCore::GPUDevice::popErrorScope): (WebCore::GPUDevice::addEventListener): * Source/WebCore/Modules/WebGPU/GPUDevice.h: * Source/WebCore/Modules/WebGPU/GPUUncapturedErrorEvent.cpp: (WebCore::GPUUncapturedErrorEvent::GPUUncapturedErrorEvent): (WebCore::GPUUncapturedErrorEvent::error const): (WebCore::GPUUncapturedErrorEvent::eventInterface const): * Source/WebCore/Modules/WebGPU/GPUUncapturedErrorEvent.h: * Source/WebCore/Modules/WebGPU/GPUUncapturedErrorEvent.idl: * Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp: (WebCore::WebGPU::DeviceImpl::~DeviceImpl): (WebCore::WebGPU::setUncapturedScopeCallback): (WebCore::WebGPU::DeviceImpl::popErrorScope): (WebCore::WebGPU::DeviceImpl::resolveUncapturedErrorEvent): * Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.h: * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUDevice.h: * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUError.h: * Source/WebCore/dom/EventInterfaces.in: * Source/WebCore/dom/TaskSource.h: * Source/WebCore/html/HTMLAttributeNames.in: * Source/WebGPU/WebGPU/Device.mm: (WebGPU::Device::generateAValidationError): (WebGPU::Device::generateAnOutOfMemoryError): (WebGPU::Device::generateAnInternalError): (WebGPU::Device::popErrorScope): * Source/WebGPU/WebGPU/Texture.mm: (WebGPU::Device::createTexture): * Source/WebKit/CMakeLists.txt: * Source/WebKit/DerivedSources-input.xcfilelist: * Source/WebKit/DerivedSources.make: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp: (WebKit::RemoteDevice::popErrorScope): (WebKit::RemoteDevice::resolveUncapturedErrorEvent): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.messages.in: * Source/WebKit/Shared/WebGPU/WebGPUError.cpp: (WebKit::WebGPU::ConvertToBackingContext::convertToBacking): (WebKit::WebGPU::ConvertFromBackingContext::convertFromBacking): * Source/WebKit/Shared/WebGPU/WebGPUError.h: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp: (WebKit::WebGPU::RemoteDeviceProxy::popErrorScope): (WebKit::WebGPU::RemoteDeviceProxy::resolveUncapturedErrorEvent): * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h: Canonical link: https://commits.webkit.org/274229@main
- Loading branch information
1 parent
3fb7287
commit 63997b1
Showing
33 changed files
with
324 additions
and
122 deletions.
There are no files selected for viewing
52 changes: 51 additions & 1 deletion
52
LayoutTests/http/tests/webgpu/webgpu/api/validation/error_scope-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,51 @@ | ||
(Populate me when we're ready to investigate this test) | ||
|
||
PASS :simple:errorType="out-of-memory";errorFilter="internal" | ||
PASS :simple:errorType="out-of-memory";errorFilter="out-of-memory" | ||
PASS :simple:errorType="out-of-memory";errorFilter="validation" | ||
PASS :simple:errorType="validation";errorFilter="internal" | ||
PASS :simple:errorType="validation";errorFilter="out-of-memory" | ||
PASS :simple:errorType="validation";errorFilter="validation" | ||
PASS :empty: | ||
PASS :parent_scope:errorFilter="out-of-memory";stackDepth=1 | ||
PASS :parent_scope:errorFilter="out-of-memory";stackDepth=10 | ||
PASS :parent_scope:errorFilter="out-of-memory";stackDepth=100 | ||
PASS :parent_scope:errorFilter="out-of-memory";stackDepth=1000 | ||
PASS :parent_scope:errorFilter="validation";stackDepth=1 | ||
PASS :parent_scope:errorFilter="validation";stackDepth=10 | ||
PASS :parent_scope:errorFilter="validation";stackDepth=100 | ||
PASS :parent_scope:errorFilter="validation";stackDepth=1000 | ||
PASS :current_scope:errorFilter="out-of-memory";stackDepth=1 | ||
PASS :current_scope:errorFilter="out-of-memory";stackDepth=10 | ||
PASS :current_scope:errorFilter="out-of-memory";stackDepth=100 | ||
PASS :current_scope:errorFilter="out-of-memory";stackDepth=1000 | ||
PASS :current_scope:errorFilter="out-of-memory";stackDepth=100000 | ||
PASS :current_scope:errorFilter="validation";stackDepth=1 | ||
PASS :current_scope:errorFilter="validation";stackDepth=10 | ||
PASS :current_scope:errorFilter="validation";stackDepth=100 | ||
PASS :current_scope:errorFilter="validation";stackDepth=1000 | ||
PASS :current_scope:errorFilter="validation";stackDepth=100000 | ||
PASS :balanced_siblings:errorFilter="internal";numErrors=1 | ||
PASS :balanced_siblings:errorFilter="internal";numErrors=10 | ||
PASS :balanced_siblings:errorFilter="internal";numErrors=100 | ||
PASS :balanced_siblings:errorFilter="internal";numErrors=1000 | ||
PASS :balanced_siblings:errorFilter="out-of-memory";numErrors=1 | ||
PASS :balanced_siblings:errorFilter="out-of-memory";numErrors=10 | ||
PASS :balanced_siblings:errorFilter="out-of-memory";numErrors=100 | ||
PASS :balanced_siblings:errorFilter="out-of-memory";numErrors=1000 | ||
PASS :balanced_siblings:errorFilter="validation";numErrors=1 | ||
PASS :balanced_siblings:errorFilter="validation";numErrors=10 | ||
PASS :balanced_siblings:errorFilter="validation";numErrors=100 | ||
PASS :balanced_siblings:errorFilter="validation";numErrors=1000 | ||
PASS :balanced_nesting:errorFilter="internal";numErrors=1 | ||
PASS :balanced_nesting:errorFilter="internal";numErrors=10 | ||
PASS :balanced_nesting:errorFilter="internal";numErrors=100 | ||
PASS :balanced_nesting:errorFilter="internal";numErrors=1000 | ||
PASS :balanced_nesting:errorFilter="out-of-memory";numErrors=1 | ||
PASS :balanced_nesting:errorFilter="out-of-memory";numErrors=10 | ||
PASS :balanced_nesting:errorFilter="out-of-memory";numErrors=100 | ||
PASS :balanced_nesting:errorFilter="out-of-memory";numErrors=1000 | ||
PASS :balanced_nesting:errorFilter="validation";numErrors=1 | ||
PASS :balanced_nesting:errorFilter="validation";numErrors=10 | ||
PASS :balanced_nesting:errorFilter="validation";numErrors=100 | ||
PASS :balanced_nesting:errorFilter="validation";numErrors=1000 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.