Skip to content

Commit

Permalink
Cherry-pick f005b55. rdar://114472398
Browse files Browse the repository at this point in the history
    REGRESSION (267279@main): [ macOS Debug ] ASSERTION FAILED: WebCore::MediaSource::completeSeek()::SeeksCallbackAggregator::SeeksCallbackAggregator
    https://bugs.webkit.org/show_bug.cgi?id=260742
    rdar://114472398

    Reviewed by Richard Robinson and Alan Baradlay.

    Fix incorrect assertion.

    Covered by tests.

    * LayoutTests/platform/mac/TestExpectations:
    * Source/WebCore/Modules/mediasource/MediaSource.cpp:
    (WebCore::MediaSource::completeSeek):

    Canonical link: https://commits.webkit.org/267314@main

Identifier: 265870.504@safari-7616-branch
  • Loading branch information
jyavenard authored and MyahCobbs committed Sep 1, 2023
1 parent a7f6cae commit 6bb178a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions LayoutTests/platform/mac/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -2862,6 +2862,3 @@ webkit.org/b/260224 [ Ventura+ ] imported/w3c/web-platform-tests/css/css-transfo
webkit.org/b/130490 media/video-remote-control-playpause.html [ Pass Timeout Crash ]

webkit.org/b/260529 [ Ventura+ x86_64 ] animations/suspend-resume-animation-events.html [ Pass Failure ]

webkit.org/b/260742 [ Monterey+ Debug ] fast/canvas/webgl/texImage2D-mse-flipY-false.html [ Crash ]
webkit.org/b/260742 [ Monterey+ Debug ] fast/canvas/webgl/texImage2D-mse-flipY-true.html [ Crash ]
2 changes: 1 addition & 1 deletion Source/WebCore/Modules/mediasource/MediaSource.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ void MediaSource::completeSeek()
, mediaSource(source)
, completionHandler(WTFMove(completionHandler))
{
ASSERT(completionHandler);
ASSERT(this->completionHandler);
}

~SeeksCallbackAggregator()
Expand Down

0 comments on commit 6bb178a

Please sign in to comment.