-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[JSC] Optimize C++ -> JS calls more by removing unnecessary callee st…
…oring to VMEntryRecord https://bugs.webkit.org/show_bug.cgi?id=265178 rdar://118672952 Reviewed by Ross Kirsling. This remoes unnecessary callee storing in VMEntryRecord. We are using it only in one place, and it is just getting JSGlobalObject when there is no JS CallFrame (then, instead, it is querying to VMEntryRecord). In this case, we can just use VMEntryScope's JSGlobalObject, which is also created before VMEntryRecord is instantiated. This removes some more unnecessary code in LowLevelInterpreter's doVMEntry. cpp-to-js-cached-call 12.8405+-0.0760 ^ 12.5615+-0.0582 ^ definitely 1.0222x faster * Source/JavaScriptCore/interpreter/CallFrame.cpp: (JSC::CallFrame::convertToStackOverflowFrame): * Source/JavaScriptCore/interpreter/VMEntryRecord.h: (JSC::VMEntryRecord::callee const): Deleted. * Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm: * Source/JavaScriptCore/llint/LowLevelInterpreter64.asm: Canonical link: https://commits.webkit.org/271027@main
- Loading branch information
1 parent
0c248b2
commit 70ed411
Showing
4 changed files
with
6 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters