-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use more smart pointers in ProcessingInstruction & PseudoElement
https://bugs.webkit.org/show_bug.cgi?id=263537 Reviewed by Ryosuke Niwa. * Source/WebCore/css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::protectedContents): * Source/WebCore/css/CSSStyleSheet.h: * Source/WebCore/dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::checkedStyleScope): (WebCore::Document::checkedStyleScope const): * Source/WebCore/dom/Document.h: (WebCore::Document::styleScope): (WebCore::Document::styleScope const): * Source/WebCore/dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::~ProcessingInstruction): (WebCore::ProcessingInstruction::checkStyleSheet): Drop some unnecessary code that was used to check if we got disconnected after firing the beforeload event (as you can see in https://commits.webkit.org/187003@main). We've stopped firing the beforeload event a while back but this code wasn't simplified. (WebCore::ProcessingInstruction::isLoading const): (WebCore::ProcessingInstruction::sheetLoaded): (WebCore::ProcessingInstruction::setCSSStyleSheet): (WebCore::ProcessingInstruction::setXSLStyleSheet): (WebCore::ProcessingInstruction::protectedSheet const): (WebCore::ProcessingInstruction::parseStyleSheet): (WebCore::ProcessingInstruction::insertedIntoAncestor): (WebCore::ProcessingInstruction::removedFromAncestor): * Source/WebCore/dom/ProcessingInstruction.h: * Source/WebCore/dom/PseudoElement.cpp: (WebCore::PseudoElement::create): (WebCore::PseudoElement::clearHostElement): * Source/WebCore/style/StyleScope.cpp: (WebCore::Style::Scope::incrementPtrCount const): (WebCore::Style::Scope::decrementPtrCount const): (WebCore::Style::Scope::createDocumentResolver): (WebCore::Style::Scope::releaseMemory): (WebCore::Style::Scope::didRemovePendingStylesheet): (WebCore::Style::Scope::addStyleSheetCandidateNode): (WebCore::Style::Scope::collectActiveStyleSheets): (WebCore::Style::Scope::updateActiveStyleSheets): (WebCore::Style::Scope::invalidateStyleAfterStyleSheetChange): (WebCore::Style::Scope::activeStyleSheetsForInspector): (WebCore::Style::Scope::flushPendingDescendantUpdates): (WebCore::Style::Scope::scheduleUpdate): (WebCore::Style::Scope::collectResolverScopes): (WebCore::Style::Scope::didChangeStyleSheetEnvironment): (WebCore::Style::Scope::didChangeViewportSize): (WebCore::Style::Scope::invalidateMatchedDeclarationsCache): (WebCore::Style::Scope::pendingUpdateTimerFired): (WebCore::Style::Scope::documentScope): (WebCore::Style::Scope::updateQueryContainerState): * Source/WebCore/style/StyleScope.h: Canonical link: https://commits.webkit.org/269694@main
- Loading branch information
Showing
9 changed files
with
113 additions
and
101 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.