-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
REGRESSION: WebGL no longer producing a transparent canvas on iOS
https://bugs.webkit.org/show_bug.cgi?id=182550 <rdar://problem/37234491> Reviewed by Eric Carlson. Due to some weirdness GL_RGBA8 is sometimes different between iOS and other platforms. Only tell the WebGLLayer that it is opaque when it really is not transparent. Covered by existing test: fast/canvas/webgl/context-attributes-alpha * platform/graphics/cocoa/GraphicsContext3DCocoa.mm: (WebCore::GraphicsContext3D::setRenderbufferStorageFromDrawable): Look at the context attributes to decide if we should use an opaque layer. * platform/graphics/cocoa/WebGLLayer.mm: Ditto. (-[WebGLLayer initWithGraphicsContext3D:]): Canonical link: https://commits.webkit.org/198343@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@228191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing
3 changed files
with
23 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters