Skip to content
Permalink
Browse files
2010-07-18 Andreas Kling <andreas.kling@nokia.com>
        Reviewed by Antonio Gomes.

        [Qt] tst_QWebElement fails firstChildNextSibling and lastChildPreviousSibling
        https://bugs.webkit.org/show_bug.cgi?id=42527

        Correct the HTML used by these tests.

        * tests/qwebelement/tst_qwebelement.cpp:
        (tst_QWebElement::firstChildNextSibling):
        (tst_QWebElement::lastChildPreviousSibling):


Canonical link: https://commits.webkit.org/54477@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Andreas Kling committed Jul 18, 2010
1 parent 46bb48b commit 7c70165a3690ed33dcea1fbda721581086c20c2e
Showing with 15 additions and 2 deletions.
  1. +13 −0 WebKit/qt/ChangeLog
  2. +2 −2 WebKit/qt/tests/qwebelement/tst_qwebelement.cpp
@@ -1,3 +1,16 @@
2010-07-18 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

[Qt] tst_QWebElement fails firstChildNextSibling and lastChildPreviousSibling
https://bugs.webkit.org/show_bug.cgi?id=42527

Correct the HTML used by these tests.

* tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::firstChildNextSibling):
(tst_QWebElement::lastChildPreviousSibling):

2010-07-16 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Adler.
@@ -887,7 +887,7 @@ void tst_QWebElement::nullSelect()

void tst_QWebElement::firstChildNextSibling()
{
m_mainFrame->setHtml("<body><!--comment--><p>Test</p><!--another commend><table>");
m_mainFrame->setHtml("<body><!--comment--><p>Test</p><!--another comment--><table>");

QWebElement body = m_mainFrame->findFirstElement("body");
QVERIFY(!body.isNull());
@@ -902,7 +902,7 @@ void tst_QWebElement::firstChildNextSibling()

void tst_QWebElement::lastChildPreviousSibling()
{
m_mainFrame->setHtml("<body><!--comment--><p>Test</p><!--another commend><table>");
m_mainFrame->setHtml("<body><!--comment--><p>Test</p><!--another comment--><table>");

QWebElement body = m_mainFrame->findFirstElement("body");
QVERIFY(!body.isNull());

0 comments on commit 7c70165

Please sign in to comment.