Skip to content

Commit

Permalink
Logger should have a virtual destructor
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=274432

Reviewed by David Kilzer and Chris Dumez.

Added the virtual destructor since AggregateLogger subclasses Logger
and has non-POD member variables.

* Source/WTF/wtf/Logger.h:
(WTF::Logger::~Logger):

Canonical link: https://commits.webkit.org/279033@main
  • Loading branch information
rniwa committed May 21, 2024
1 parent 72bf18f commit 7d4bbc7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Source/WTF/wtf/Logger.h
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ WTF_EXPORT_PRIVATE extern Lock loggerObserverLock;
class Logger : public ThreadSafeRefCounted<Logger> {
WTF_MAKE_NONCOPYABLE(Logger);
public:
virtual ~Logger() { }

class Observer {
public:
Expand Down

0 comments on commit 7d4bbc7

Please sign in to comment.