Crash in gamepads in WKWebView apps that also listen to the GameContr…

…oller framework themselves

https://bugs.webkit.org/show_bug.cgi?id=247368 and rdar://100036005

Reviewed by Geoff Garen.

No test possible for now.

* Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp:
(WebKit::UIGamepadProvider::platformGamepadInputActivity): Handle a mismatch between platform gamepads
  and established gamepads. This can happen when there's "invisible" gamepads still, and the current
  input event will not reveal them to WebContent. And it's fine: Things get resolved when an input
  even *does* reveal the gamepads to the web page.

Canonical link: https://commits.webkit.org/256255@main

Source/WebKit/UIProcess/Gamepad/UIGamepadProvider.cpp

@@ -114,15 +114,12 @@ void UIGamepadProvider::platformGamepadDisconnected(PlatformGamepad& gamepad)
 void UIGamepadProvider::platformGamepadInputActivity(EventMakesGamepadsVisible eventVisibility)
 {
     auto platformGamepads = GamepadProvider::singleton().platformGamepads();
-    ASSERT(platformGamepads.size() == m_gamepads.size());
 
-    for (size_t i = 0; i < platformGamepads.size(); ++i) {
-        if (!platformGamepads[i]) {
-            ASSERT(!m_gamepads[i]);
+    auto end = std::min(m_gamepads.size(), platformGamepads.size());
+    for (size_t i = 0; i < end; ++i) {
+        if (!m_gamepads[i] || !platformGamepads[i])
             continue;
-        }
 
-        ASSERT(m_gamepads[i]);
         m_gamepads[i]->updateFromPlatformGamepad(*platformGamepads[i]);
     }