Skip to content

Commit

Permalink
[ macOS Debug WK2 ] ASSERT call in RenderVTTCue.cpp causing flaky cra…
Browse files Browse the repository at this point in the history
…sh (media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html)

https://bugs.webkit.org/show_bug.cgi?id=259544
rdar://112951082

Reviewed by Jer Noble.

Remove two unneeded asserts. Both checked a condition that is commonly encountered and which
is not dangerous or harmful.

* LayoutTests/platform/mac-wk2/TestExpectations: Unskip test.

* Source/WebCore/rendering/RenderVTTCue.cpp:
(WebCore::RenderVTTCue::repositionCueSnapToLinesSet): Remove assert.
(WebCore::RenderVTTCue::repositionGenericCue): Ditto.

Canonical link: https://commits.webkit.org/266513@main
  • Loading branch information
eric-carlson committed Aug 2, 2023
1 parent f3a7c01 commit 83a6562
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions LayoutTests/platform/mac-wk2/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -1826,8 +1826,6 @@ webkit.org/b/259496 [ x86_64 ] imported/w3c/web-platform-tests/webcodecs/tempora

webkit.org/b/238033 imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-050.html [ Pass Failure ]

webkit.org/b/259544 [ Debug ] media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html [ Pass Crash ]

webkit.org/b/259183 fast/attachment/mac/wide-attachment-image-controls-basic.html [ Pass Failure ]

webkit.org/b/259699 media/media-source/media-source-duplicate-seeked.html [ Pass Failure ]
Expand Down
2 changes: 0 additions & 2 deletions Source/WebCore/rendering/RenderVTTCue.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,6 @@ void RenderVTTCue::repositionCueSnapToLinesSet()
if (!initializeLayoutParameters(step, position))
return;

ASSERT(firstChild());
if (!firstChild())
return;

Expand Down Expand Up @@ -377,7 +376,6 @@ void RenderVTTCue::repositionCueSnapToLinesSet()

void RenderVTTCue::repositionGenericCue()
{
ASSERT(firstChild());
if (!firstChild())
return;

Expand Down

0 comments on commit 83a6562

Please sign in to comment.