-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ThreadSafeWeakHashSet::contains should return false if object has beg…
…un destruction https://bugs.webkit.org/show_bug.cgi?id=259966 rdar://113608976 Reviewed by Chris Dumez. In #16413 we found that it returns true, but only if the amortized cleanup hasn't removed its null ThreadSafeWeakPtr from the map yet. This is undesirable because the amortized cleanup shouldn't affect behavior. To fix this, just make it return false in this case. * Source/WTF/wtf/ThreadSafeWeakHashSet.h: * Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp: (TestWebKitAPI::ObjectAddingAndRemovingItself::~ObjectAddingAndRemovingItself): Canonical link: https://commits.webkit.org/266764@main
- Loading branch information
1 parent
66ec7a0
commit 870ff92
Showing
2 changed files
with
18 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters