-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[IFC] Cache canUseSimplifiedTextMeasuring on RenderText
https://bugs.webkit.org/show_bug.cgi?id=260426 Reviewed by Antti Koivisto. 1. Computing canUseSimplifiedTextMeasuring is an expensive operation (it may iterate through all the glyphs of the text content) 2. We used to cache this information on RenderText (see 260675@main) and now it's computed at BoxTree building. 3. Due to eager (IFC integration) invalidation, we destroy BoxTree in cases where we still keep associated RenderText renderers alive. ~10% progression on PerformanceTests/Layout/line-layout-preferred-width-break-all.html * PerformanceTests/Layout/line-layout.html: * Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp: (WebCore::LayoutIntegration::BoxTree::createLayoutBox): * Source/WebCore/rendering/RenderText.cpp: (WebCore::RenderText::setRenderedText): * Source/WebCore/rendering/RenderText.h: (WebCore::RenderText::setCanUseSimplifiedTextMeasuring): (WebCore::RenderText::canUseSimplifiedTextMeasuring const): Canonical link: https://commits.webkit.org/267081@main
- Loading branch information
1 parent
cf8be61
commit 8f6d89b
Showing
3 changed files
with
15 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters