Skip to content
Permalink
Browse files
[BlackBerry] canvas is not rendering correctly for www.html5-benchmar…
…k.com

https://bugs.webkit.org/show_bug.cgi?id=113716

Patch by Konrad Piascik <kpiascik@blackberry.com> on 2013-04-01
Reviewed by Rob Buis.

PR 317205
Internally reivewed by: Mike Lattanzio, Jacky Jiang

This is a site issue where they detect physical pixels by multiplying
availWidth * devicePixelRatio.  This gives us an invalid result since
we don't round the CSS pixels that are reported to availWidth and availHeight.

* platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::toUserSpace):

Canonical link: https://commits.webkit.org/132067@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Konrad Piascik authored and webkit-commit-queue committed Apr 2, 2013
1 parent db818ad commit 94ca14921abff4e24884d062b187f50efd673cd5
Showing 2 changed files with 20 additions and 1 deletion.
@@ -1,3 +1,20 @@
2013-04-01 Konrad Piascik <kpiascik@blackberry.com>

[BlackBerry] canvas is not rendering correctly for www.html5-benchmark.com
https://bugs.webkit.org/show_bug.cgi?id=113716

Reviewed by Rob Buis.

PR 317205
Internally reivewed by: Mike Lattanzio, Jacky Jiang

This is a site issue where they detect physical pixels by multiplying
availWidth * devicePixelRatio. This gives us an invalid result since
we don't round the CSS pixels that are reported to availWidth and availHeight.

* platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::toUserSpace):

2013-04-01 Hans Muller <hmuller@adobe.com>

[CSS Exclusions] shape-outside on floats fails to respect shape-margin's vertical extent
@@ -52,8 +52,10 @@ static FloatRect toUserSpace(FloatRect rect, Widget* widget)
{
if (widget->isFrameView()) {
Page* page = toFrameView(widget)->frame()->page();
if (page && !page->settings()->applyDeviceScaleFactorInCompositor())
if (page && !page->settings()->applyDeviceScaleFactorInCompositor()) {
rect.scale(1 / page->deviceScaleFactor());
rect.setSize(expandedIntSize(rect.size()));
}
}
return rect;
}

0 comments on commit 94ca149

Please sign in to comment.