-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Cherry-pick 272846@main (8395281). https://bugs.webkit.org/show_bug.c…
…gi?id=267331 [iFC][Ruby] frameset with display:none crashes in ruby https://bugs.webkit.org/show_bug.cgi?id=267331 rdar://120496400 Reviewed by Alan Baradlay. <frameset> generates a renderer even with 'display:none' breaking some assumptions. * LayoutTests/fast/ruby/ruby-frameset-display-none-crash-expected.txt: Added. * LayoutTests/fast/ruby/ruby-frameset-display-none-crash.html: Added. * Source/WebCore/html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::rendererIsNeeded): * Source/WebCore/html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::rendererIsNeeded): Deleted. * Source/WebCore/html/HTMLFrameSetElement.h: * Source/WebCore/style/StyleAdjuster.cpp: (WebCore::Style::Adjuster::adjust const): Adjust frameset/frame always have 'display:block', even when it is orginally 'none'. This matches other browsers. Canonical link: https://commits.webkit.org/272846@main
- Loading branch information
Showing
6 changed files
with
23 additions
and
17 deletions.
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
LayoutTests/fast/ruby/ruby-frameset-display-none-crash-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
This test passes if it doesn't crash. |
14 changes: 14 additions & 0 deletions
14
LayoutTests/fast/ruby/ruby-frameset-display-none-crash.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
This test passes if it doesn't crash. | ||
<style> | ||
frameset { display:none } | ||
</style> | ||
<script> | ||
if (window.testRunner) | ||
testRunner.dumpAsText(); | ||
|
||
function test() { | ||
ruby.appendChild(document.createElement("frameset")); | ||
} | ||
</script> | ||
<body onload=test()> | ||
<ruby id="ruby"></ruby> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters