Skip to content

Commit

Permalink
REGRESSION(268368@main): causes an assertion failure for http tests
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=262016

Unreviewed revert 268368@main partially.

* Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage):
(WTR::InjectedBundle::beginTesting):

Canonical link: https://commits.webkit.org/268377@main
  • Loading branch information
fujii committed Sep 24, 2023
1 parent 2f74816 commit aa8ce99
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,6 @@ void InjectedBundle::didReceiveMessageToPage(WKBundlePageRef page, WKStringRef m
TestRunner::removeAllWebNotificationPermissions();

InjectedBundle::page()->resetAfterTest();

#if ENABLE(VIDEO)
WKBundlePageSetCaptionDisplayTestingMode(InjectedBundle::page()->page(), false);
#endif
}
return;
}
Expand Down Expand Up @@ -584,7 +580,6 @@ void InjectedBundle::beginTesting(WKDictionaryRef settings, BegingTestingMode te
clearResourceLoadStatistics();

#if ENABLE(VIDEO)
WKBundlePageSetCaptionDisplayTestingMode(page()->page(), true);
WKBundleSetCaptionDisplayMode(page()->page(), stringValue(settings, "CaptionDisplayMode"));
#endif
// [WK2] REGRESSION(r128623): It made layout tests extremely slow
Expand Down

0 comments on commit aa8ce99

Please sign in to comment.