-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid calling updateCompositingLayers() more than once before each re…
…nder. https://bugs.webkit.org/show_bug.cgi?id=84393 <rdar://11359525> Reviewed by Simon Fraser. Calling updateCompositingLayers after each layout causes unnecessary work, since the layers might change again before rendering. This change defers this work until Page::updateRendering if possible, and improves performance on pages that force layout flushes outside of rendering. * LayoutTests/compositing/overflow/scrolling-without-painting.html: * LayoutTests/compositing/overflow/updating-scrolling-content.html: * LayoutTests/compositing/scrolling/touch-scroll-to-clip.html: * LayoutTests/compositing/updates/no-style-change-updates.html: * LayoutTests/editing/editable-region/iframe-expected.txt: * LayoutTests/fast/css/transform-function-perspective-crash.html: * LayoutTests/fast/scrolling/iframe-scrollable-after-back.html: * LayoutTests/fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hit-test.html: * LayoutTests/fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered.html: * LayoutTests/inspector/layers/layerTreeDidChange.html: * LayoutTests/platform/gtk/compositing/scrolling/touch-scroll-to-clip-expected.txt: Copied from LayoutTests/platform/ios/compositing/overflow/updating-scrolling-content-expected.txt. * LayoutTests/platform/ios/compositing/overflow/updating-scrolling-content-expected.txt: * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/wpe/TestExpectations: * LayoutTests/platform/wpe/fast/text/mark-matches-overflow-clip-expected.txt: * LayoutTests/scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow-nested.html: * LayoutTests/scrollingcoordinator/scrolling-tree/clipped-layer-in-overflow.html: * LayoutTests/scrollingcoordinator/scrolling-tree/fixed-inside-relative-inside-stacking-overflow-inside-transformed.html: * LayoutTests/scrollingcoordinator/scrolling-tree/fixed-inside-stacking-overflow-inside-transformed.html: * LayoutTests/tiled-drawing/scrolling/clamp-out-of-bounds-scrolls.html: * LayoutTests/tiled-drawing/scrolling/scrolling-tree-after-scroll.html: * LayoutTests/tiled-drawing/scrolling/slow-scrolling.html: * Source/WebCore/dom/Document.cpp: (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::updateLayout): (WebCore::Document::implicitClose): * Source/WebCore/dom/Document.h: (WebCore::Document::updateLayout): (WebCore::Document::updateLayoutIgnorePendingStylesheets): * Source/WebCore/dom/Element.cpp: (WebCore::Element::scrollIntoView): (WebCore::Element::scrollIntoViewIfNeeded): (WebCore::Element::scrollIntoViewIfNotVisible): (WebCore::Element::scrollTo): (WebCore::Element::scrollByUnits): * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): * Source/WebCore/page/LocalDOMWindow.cpp: (WebCore::LocalDOMWindow::scrollTo const): * Source/WebCore/page/LocalFrameView.cpp: (WebCore::LocalFrameView::updateCompositingLayersAfterLayout): (WebCore::LocalFrameView::updateCompositingLayersAfterLayoutIfNeeded): (WebCore::LocalFrameView::didLayout): (WebCore::LocalFrameView::updateLayoutAndStyleIfNeededRecursive): (WebCore::LocalFrameView::setTracksRepaints): * Source/WebCore/page/LocalFrameView.h: * Source/WebCore/page/Page.cpp: (WebCore::Page::scrollingStateTreeAsText): (WebCore::Page::setPageScaleFactor): (WebCore::Page::layoutIfNeeded): (WebCore::Page::updateRendering): (WebCore::Page::doAfterUpdateRendering): * Source/WebCore/page/Page.h: (WebCore::Page::layoutIfNeeded): * Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated): (WebCore::AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged): (WebCore::AsyncScrollingCoordinator::setEventTrackingRegionsDirty): Deleted. * Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h: * Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingForLayerTreeAsTextDump): * Source/WebCore/rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): (WebCore::updateLayoutIgnoringPendingStylesheetsIncludingSubframes): Deleted. Canonical link: https://commits.webkit.org/271261@main
- Loading branch information
1 parent
7445f27
commit b6b7455
Showing
33 changed files
with
212 additions
and
106 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
LayoutTests/platform/wpe/fast/text/mark-matches-overflow-clip-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
marker rects: (24.671875, 93, 46, 18) | ||
marker rects: (58, 93, 12.6719, 18) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.