Skip to content

Commit

Permalink
REGRESSION ( 271130@main ): [ macOS wk1 ] 4 tests in http/tests/secur…
Browse files Browse the repository at this point in the history 
…ity/mixedContent are a consistent failure

https://bugs.webkit.org/show_bug.cgi?id=265388
rdar://118836741

Reviewed by Alex Christensen.

Remove console output for WebKitLegacy as it varies per run and became
much worse after removing a preference.

* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/mac-wk1/http/tests/security/mixedContent/insecure-image-redirects-to-basic-auth-secure-image-expected.txt:
* LayoutTests/platform/mac-wk1/http/tests/security/mixedContent/secure-redirect-to-insecure-redirect-to-basic-auth-secure-image.https-expected.txt:
* LayoutTests/platform/mac-wk1/http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-insecure-image.https-expected.txt: Added.
* LayoutTests/platform/mac-wk1/http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-secure-image.https-expected.txt:

Canonical link: https://commits.webkit.org/271220@main
  • Loading branch information
@annevk
annevk committed Nov 28, 2023
1 parent 92895f3 commit bb9db9e
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 19 deletions.
10 changes: 4 additions & 6 deletions LayoutTests/platform/mac-wk1/TestExpectations
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2481,6 +2481,10 @@ http/tests/security/contentSecurityPolicy/video-with-https-url-allowed-by-csp-me
http/tests/security/mixedContent/websocket/insecure-websocket-in-iframe.html [ Pass Failure ]
http/tests/security/contentSecurityPolicy/script-src-parsing-implicit-and-explicit-port-number.html [ DumpJSConsoleLogInStdErr ]
imported/w3c/web-platform-tests/webmessaging/broadcastchannel/cross-partition.https.tentative.html [ DumpJSConsoleLogInStdErr ]
http/tests/security/mixedContent/insecure-image-redirects-to-basic-auth-secure-image.html [ DumpJSConsoleLogInStdErr ]
http/tests/security/mixedContent/secure-redirect-to-insecure-redirect-to-basic-auth-secure-image.https.html [ DumpJSConsoleLogInStdErr ]
http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-insecure-image.https.html [ DumpJSConsoleLogInStdErr ]
http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-secure-image.https.html [ DumpJSConsoleLogInStdErr ]

# These tests have been flaky on WK1 since their import.
imported/w3c/web-platform-tests/websockets/basic-auth.any.html?wss [ Pass Failure ]
Expand Down Expand Up @@ -2711,9 +2715,3 @@ imported/w3c/web-platform-tests/css/css-backgrounds/background-size/background-s

# webkit.org/b/263870 [scroll-animations] lots of scroll-animations WPT tests are timing out
imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/scroll-timeline-snapshotting.html [ Skip ]

# rdar://118836741 (REGRESSION ( 271130@main ): [ macOS wk1 ] 4 tests in http/tests/security/mixedContent are a consistent failure)
http/tests/security/mixedContent/insecure-image-redirects-to-basic-auth-secure-image.html [ Pass Failure ]
http/tests/security/mixedContent/secure-redirect-to-insecure-redirect-to-basic-auth-secure-image.https.html [ Pass Failure ]
http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-insecure-image.https.html [ Pass Failure ]
http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-secure-image.https.html [ Pass Failure ]
5 changes: 0 additions & 5 deletions ...ts/security/mixedContent/insecure-image-redirects-to-basic-auth-secure-image-expected.txt
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
CONSOLE MESSAGE: The page at https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-image-redirects-to-basic-auth-secure-image.html was allowed to display insecure content from http://127.0.0.1:8080/resources/redirect.py?url=https://localhost:8443/security/mixedContent/resources/subresource/protected-image.py.

CONSOLE MESSAGE: Blocked https://localhost:8443/security/mixedContent/resources/subresource/protected-image.py from asking for credentials because it is a cross-origin request.
CONSOLE MESSAGE: Blocked https://localhost:8443/security/mixedContent/resources/subresource/protected-image.py from asking for credentials because it is a cross-origin request.
CONSOLE MESSAGE: Blocked https://localhost:8443/security/mixedContent/resources/subresource/protected-image.py from asking for credentials because it is a cross-origin request.
This test opens a new window to a secure page that loads an insecure image that redirects to a secure image guarded by basic authentication. The secure image should be blocked because it requires credentials and was loaded via an insecure redirect.

PASS did not load image.
5 changes: 0 additions & 5 deletions ...ontent/secure-redirect-to-insecure-redirect-to-basic-auth-secure-image.https-expected.txt
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
CONSOLE MESSAGE: The page at https://127.0.0.1:8443/security/mixedContent/secure-redirect-to-insecure-redirect-to-basic-auth-secure-image.https.html was allowed to display insecure content from http://127.0.0.1:8080/resources/redirect.py?url=https://localhost:8443/security/mixedContent/resources/subresource/protected-image.py.

CONSOLE MESSAGE: Blocked https://localhost:8443/security/mixedContent/resources/subresource/protected-image.py from asking for credentials because it is a cross-origin request.
CONSOLE MESSAGE: Blocked https://localhost:8443/security/mixedContent/resources/subresource/protected-image.py from asking for credentials because it is a cross-origin request.
CONSOLE MESSAGE: Blocked https://localhost:8443/security/mixedContent/resources/subresource/protected-image.py from asking for credentials because it is a cross-origin request.
This test loads a secure image that redirects to an insecure image that redirects to a secure image guarded by basic authentication. The secure image should be blocked because it requires credentials and was loaded via an insecure redirect.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Expand Down
10 changes: 10 additions & 0 deletions ...ontent/secure-redirect-to-secure-redirect-to-basic-auth-insecure-image.https-expected.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
This test loads a secure image that redirects to an secure image that redirects to an insecure image guarded by basic authentication. The insecure image should be blocked because it requires credentials.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


PASS did not load image.
PASS successfullyParsed is true

TEST COMPLETE

3 changes: 0 additions & 3 deletions ...dContent/secure-redirect-to-secure-redirect-to-basic-auth-secure-image.https-expected.txt
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
CONSOLE MESSAGE: Blocked https://localhost:8443/security/mixedContent/resources/subresource/protected-image.py from asking for credentials because it is a cross-origin request.
CONSOLE MESSAGE: Blocked https://localhost:8443/security/mixedContent/resources/subresource/protected-image.py from asking for credentials because it is a cross-origin request.
CONSOLE MESSAGE: Blocked https://localhost:8443/security/mixedContent/resources/subresource/protected-image.py from asking for credentials because it is a cross-origin request.
This test loads a secure image that redirects to a secure image that redirects to a secure image guarded by basic authentication. The secure image should not load because it is cross-origin.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Expand Down

0 comments on commit bb9db9e

Please sign in to comment.