-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Cherry-pick 276012@main (910ab18). https://bugs.webkit.org/show_bug.c…
…gi?id=269377 [WPE][GTK] Warning: WebKit2: Couldn't find 'run_async_javascript_function_in_world_finish' for the corresponding async function: 'run_async_javascript_function_in_world' https://bugs.webkit.org/show_bug.cgi?id=269377 Reviewed by Adrian Perez de Castro. We need to use the new finish-func annotation so that language bindings can figure out how to complete the async call, due to our nonstandard naming for the finish function. It seems trying to reuse the same finish function for multiple async calls was not such a good idea. Unfortunately, with older gobject-introspection, we cannot use this new annotation or the build will fail due to the unrecognized annotation. So we will need to conditionalize the entire doc comment. Finally, I've also fixed the nullability of the world_name parameter, which was broken due to a missing colon. * Source/WebKit/PlatformGTK.cmake: * Source/WebKit/PlatformWPE.cmake: * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: * Source/WebKit/UIProcess/API/glib/WebKitWebView.h.in: Canonical link: https://commits.webkit.org/276012@main Canonical link: https://commits.webkit.org/274313.87@webkitglib/2.44
- Loading branch information
1 parent
3cf2b08
commit bcd671b
Showing
4 changed files
with
158 additions
and
69 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters