-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Cherry-pick 4c34308. rdar://118267012
Crash under PAL::newTextCodec(PAL::TextEncoding const&) https://bugs.webkit.org/show_bug.cgi?id=264979 rdar://118267012 Reviewed by Brent Fulgham. There is evidence for crashes in the wild that the CachedCSSStyleSheet or the TextResourceDecoder are being used after getting freed. To prevent this, protect both these objects in the code path identified by the crashes. This is a speculative fix but it should be very safe. * Source/WebCore/loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didFinishLoading): * Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::finishLoading): (WebCore::CachedCSSStyleSheet::protectedDecoder const): * Source/WebCore/loader/cache/CachedCSSStyleSheet.h: Canonical link: https://commits.webkit.org/267815.575@safari-7617-branch Identifier: 267815.572@safari-7617.1.17.11-branch
- Loading branch information
Showing
3 changed files
with
24 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters