Addressing review feedback from 267490@main

https://bugs.webkit.org/show_bug.cgi?id=260956 rdar://114751994 Reviewed by Simon Fraser. Addressing review feedback from #17269 (review) * Source/WTF/wtf/text/TextStream.cpp: (WTF::TextStream::operator<<): * Source/WTF/wtf/text/TextStream.h: * Tools/TestWebKitAPI/Tests/WTF/cocoa/TextStreamCocoa.cpp: (TEST): Canonical link: https://commits.webkit.org/267493@main
WebKit · Aug 31, 2023 · c3b8ad1 · c3b8ad1
1 parent 3ebb0e8
commit c3b8ad1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/Source/WTF/wtf/text/TextStream.cpp b/Source/WTF/wtf/text/TextStream.cpp
@@ -142,7 +142,7 @@ TextStream& TextStream::operator<<(StringView string)
     return *this;
 }
 
-TextStream& TextStream::operator<<(HexNumberBuffer buffer)
+TextStream& TextStream::operator<<(const HexNumberBuffer& buffer)
 {
     m_text.append(makeString(buffer));
     return *this;

diff --git a/Source/WTF/wtf/text/TextStream.h b/Source/WTF/wtf/text/TextStream.h
@@ -78,7 +78,7 @@ class TextStream {
     WTF_EXPORT_PRIVATE TextStream& operator<<(const String&);
     WTF_EXPORT_PRIVATE TextStream& operator<<(ASCIILiteral);
     WTF_EXPORT_PRIVATE TextStream& operator<<(StringView);
-    WTF_EXPORT_PRIVATE TextStream& operator<<(HexNumberBuffer);
+    WTF_EXPORT_PRIVATE TextStream& operator<<(const HexNumberBuffer&);
     // Deprecated. Use the NumberRespectingIntegers FormattingFlag instead.
     WTF_EXPORT_PRIVATE TextStream& operator<<(const FormatNumberRespectingIntegers&);
 

diff --git a/Tools/TestWebKitAPI/Tests/WTF/cocoa/TextStreamCocoa.cpp b/Tools/TestWebKitAPI/Tests/WTF/cocoa/TextStreamCocoa.cpp
@@ -38,6 +38,6 @@ TEST(WTF_TextStream, CFString)
 TEST(WTF_TextStream, Hex)
 {
     TextStream ts;
-    ts << hex(18);
-    EXPECT_EQ(ts.release(), "12"_s);
+    ts << hex(31);
+    EXPECT_EQ(ts.release(), "1F"_s);
 }