Add null check in CheckboxInputType::performSwitchAnimation

https://bugs.webkit.org/show_bug.cgi?id=267429 rdar://120841254 Reviewed by Tim Nguyen. * LayoutTests/fast/forms/checkbox-click-without-renderer-expected.txt: Added. * LayoutTests/fast/forms/checkbox-click-without-renderer.html: Added. * Source/WebCore/html/CheckboxInputType.cpp: (WebCore::CheckboxInputType::performSwitchAnimation): Canonical link: https://commits.webkit.org/272956@main
WebKit · Jan 12, 2024 · c620752 · c620752
1 parent 67e8a20
commit c620752
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/LayoutTests/fast/forms/checkbox-click-without-renderer-expected.txt b/LayoutTests/fast/forms/checkbox-click-without-renderer-expected.txt
@@ -0,0 +1 @@
+This test passes if it does not crash.
diff --git a/LayoutTests/fast/forms/checkbox-click-without-renderer.html b/LayoutTests/fast/forms/checkbox-click-without-renderer.html
@@ -0,0 +1,10 @@
+<script>
+  if (window.testRunner) { testRunner.dumpAsText() }
+  let input0 = document.createElement('input');
+  input0.type = 'checkbox';
+  input0.switch = true;
+  let label0 = document.createElement('label');
+  label0.append(input0);
+  label0.click();
+</script>
+This test passes if it does not crash.
diff --git a/Source/WebCore/html/CheckboxInputType.cpp b/Source/WebCore/html/CheckboxInputType.cpp
@@ -334,9 +334,7 @@ void CheckboxInputType::performSwitchAnimation(SwitchAnimationType type)
 {
     ASSERT(isSwitch());
     ASSERT(element());
-    ASSERT(element()->renderer());
-
-    if (!element()->renderer()->style().hasEffectiveAppearance())
+    if (!element()->renderer() || !element()->renderer()->style().hasEffectiveAppearance())
         return;
 
     auto updateInterval = switchAnimationUpdateInterval(element());