Skip to content

Commit

Permalink
Fails to build with GCC 13 due to overloaded-virtual error in FilterE…
Browse files Browse the repository at this point in the history
…ffect

https://bugs.webkit.org/show_bug.cgi?id=259729

Reviewed by Said Abou-Hallawa.

FilterEffect.h:44:18: error: ‘virtual bool WebCore::FilterEffect::operator==(const WebCore::FilterEffect&) const’ was hidden [-Werror=overloaded-virtual=]
   44 |     virtual bool operator==(const FilterEffect&) const;
      |                  ^~~~~~~~
FELighting.h:42:10: note:   by ‘bool WebCore::FELighting::operator==(const WebCore::FELighting&) const’
   42 |     bool operator==(const FELighting&) const;
      |          ^~~~~~~~

* Source/WebCore/platform/graphics/filters/FELighting.h:

Canonical link: https://commits.webkit.org/266539@main
  • Loading branch information
carlosgcampos committed Aug 3, 2023
1 parent dc07956 commit c85962a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Source/WebCore/platform/graphics/filters/FELighting.h
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ class FELighting : public FilterEffect {
protected:
FELighting(Type, const Color& lightingColor, float surfaceScale, float diffuseConstant, float specularConstant, float specularExponent, float kernelUnitLengthX, float kernelUnitLengthY, Ref<LightSource>&&);

using FilterEffect::operator==;

FloatRect calculateImageRect(const Filter&, std::span<const FloatRect> inputImageRects, const FloatRect& primitiveSubregion) const override;

std::unique_ptr<FilterEffectApplier> createSoftwareApplier() const override;
Expand Down

0 comments on commit c85962a

Please sign in to comment.