Skip to content

Commit

Permalink
Unreviewed, fix the internal tvOS build after 268744@main
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=262471
rdar://115803976

The `LPMetadataProvider` class is unavailable on tvOS; guard softlinking definitions and
declarations, along with SPI declaractions, behind a `!PLATFORM(APPLETV)` check.

* Source/WebCore/PAL/pal/cocoa/LinkPresentationSoftLink.h:
* Source/WebCore/PAL/pal/cocoa/LinkPresentationSoftLink.mm:
* Source/WebCore/PAL/pal/spi/cocoa/LinkPresentationSPI.h:

Canonical link: https://commits.webkit.org/268754@main
  • Loading branch information
whsieh committed Oct 2, 2023
1 parent 297cfba commit caa99e9
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
3 changes: 3 additions & 0 deletions Source/WebCore/PAL/pal/cocoa/LinkPresentationSoftLink.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,7 @@
SOFT_LINK_FRAMEWORK_FOR_HEADER(PAL, LinkPresentation)

SOFT_LINK_CLASS_FOR_HEADER(PAL, LPLinkMetadata)

#if !PLATFORM(APPLETV)
SOFT_LINK_CLASS_FOR_HEADER(PAL, LPMetadataProvider)
#endif
3 changes: 3 additions & 0 deletions Source/WebCore/PAL/pal/cocoa/LinkPresentationSoftLink.mm
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,7 @@
SOFT_LINK_FRAMEWORK_FOR_SOURCE(PAL, LinkPresentation)

SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT(PAL, LinkPresentation, LPLinkMetadata, PAL_EXPORT)

#if !PLATFORM(APPLETV)
SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT(PAL, LinkPresentation, LPMetadataProvider, PAL_EXPORT)
#endif
4 changes: 4 additions & 0 deletions Source/WebCore/PAL/pal/spi/cocoa/LinkPresentationSPI.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,12 @@
- (void)_setIncomplete:(BOOL)incomplete;
@end

#if !PLATFORM(APPLETV)

@interface LPMetadataProvider ()
- (LPLinkMetadata *)_startFetchingMetadataForURL:(NSURL *)URL completionHandler:(void(^)(NSError *))completionHandler;
@end

#endif // !PLATFORM(APPLETV)

#endif // USE(APPLE_INTERNAL_SDK)

0 comments on commit caa99e9

Please sign in to comment.