-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Font] Fix "system-ui" font family within <canvas>
https://bugs.webkit.org/show_bug.cgi?id=263719 rdar://117231545 Reviewed by Tim Nguyen. The "system-ui" font family is expected down the line (in /platform code) to be a string like a user font and not the CSS prefixed keyword. * LayoutTests/fast/canvas/font-family-system-ui-canvas-expected-mismatch.html: Added. * LayoutTests/fast/canvas/font-family-system-ui-canvas.html: Added. * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/wpe/TestExpectations: * Source/WebCore/style/StyleResolveForFontRaw.cpp: (WebCore::Style::resolveForFontRaw): Canonical link: https://commits.webkit.org/269873@main
- Loading branch information
Showing
5 changed files
with
27 additions
and
3 deletions.
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
LayoutTests/fast/canvas/font-family-system-ui-canvas-expected-mismatch.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<canvas id="myCanvas" width="200" height="100"></canvas> | ||
|
||
<script> | ||
var c = document.getElementById("myCanvas"); | ||
var ctx = c.getContext("2d"); | ||
ctx.font = "30px serif"; | ||
ctx.fillText("Hello World", 10, 50); | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<canvas id="myCanvas" width="200" height="100"></canvas> | ||
|
||
<script> | ||
var c = document.getElementById("myCanvas"); | ||
var ctx = c.getContext("2d"); | ||
ctx.font = "30px system-ui"; | ||
ctx.fillText("Hello World", 10, 50); | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters