Unreviewed, reverting 270583@main.

https://bugs.webkit.org/show_bug.cgi?id=264758 Introduced crash Reverted changeset: "Enable management of WebKit process as extensions by default" https://bugs.webkit.org/show_bug.cgi?id=264316 https://commits.webkit.org/270583@main Canonical link: https://commits.webkit.org/270668@main
WebKit · Nov 13, 2023 · cfb0ad5 · cfb0ad5
1 parent 6c526fb
commit cfb0ad5
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm b/Source/WebKit/UIProcess/Cocoa/ProcessAssertionCocoa.mm
@@ -377,7 +377,7 @@ - (void)assertion:(RBSAssertion *)assertion didInvalidateWithError:(NSError *)er
     , m_reason(reason)
 {
 #if USE(EXTENSIONKIT)
-    if (process.extensionProcess()) {
+    if (AuxiliaryProcessProxy::manageProcessesAsExtensions()) {
         NSString *runningBoardAssertionName = runningBoardNameForAssertionType(m_assertionType);
         NSString *runningBoardDomain = runningBoardDomainForAssertionType(m_assertionType);
         m_capabilities = [get_SECapabilitiesClass() assertionWithDomain:runningBoardDomain name:runningBoardAssertionName];

diff --git a/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm b/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
@@ -306,8 +306,7 @@ static void logProcessPoolState(const WebProcessPool& pool)
     });
 
 #if USE(EXTENSIONKIT)
-    bool manageProcessesAsExtensions = !CFPreferencesGetAppBooleanValue(CFSTR("disableProcessesAsExtensions"), kCFPreferencesCurrentApplication, nullptr);
-    AuxiliaryProcessProxy::setManageProcessesAsExtensions(manageProcessesAsExtensions);
+    AuxiliaryProcessProxy::setManageProcessesAsExtensions(CFPreferencesGetAppBooleanValue(CFSTR("manageProcessesAsExtensions"), CFSTR("com.apple.WebKit"), nullptr));
 #endif
 }
 

diff --git a/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm b/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
@@ -321,11 +321,6 @@ static void setVideoDecoderBehaviors(OptionSet<VideoDecoderBehavior> videoDecode
 {
     WEBPROCESS_RELEASE_LOG(Process, "WebProcess::platformInitializeWebProcess");
 
-#if USE(EXTENSIONKIT)
-    // Workaround for crash seen when running tests. See rdar://118186487.
-    unsetenv("BSServiceDomains");
-#endif
-
     applyProcessCreationParameters(parameters.auxiliaryProcessParameters);
 
     setQOS(parameters.latencyQOS, parameters.throughputQOS);