Skip to content

Commit

Permalink
Backport fix for erroneous CSE of EnumeratorNextUpdateIndexAndMode an…
Browse files Browse the repository at this point in the history
…d HasIndexedProperty

rdar://110785576

Reviewed by Michael Saboff, Justin Michaud and Yusuke Suzuki.

Backports part of https://commits.webkit.org/263909@main, which
prevents erroneous elimination of an EnumeratorNextUpdateIndexAndMode
and HasIndexedProperty node pair if they have the same operands.
The full commit in 263909@main depends on the existence of DFG tuples,
which haven't yet been brought into the security branch, so those
parts are omitted from this patch.

* Source/JavaScriptCore/dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* Source/JavaScriptCore/dfg/DFGHeapLocation.cpp:
(WTF::printInternal):
* Source/JavaScriptCore/dfg/DFGHeapLocation.h:

Originally-landed-as: 259548.828@safari-7615-branch (01e86f1). rdar://110785576
Canonical link: https://commits.webkit.org/266389@main
  • Loading branch information
ddegazio authored and robert-jenner committed Jul 28, 2023
1 parent 45a531f commit d771407
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Source/JavaScriptCore/dfg/DFGHeapLocation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ void printInternal(PrintStream& out, LocationKind kind)
case GlobalVariableLoc:
out.print("GlobalVariableLoc");
return;

case HasIndexedPropertyLoc:
out.print("HasIndexedPorpertyLoc");
return;
Expand Down

0 comments on commit d771407

Please sign in to comment.