Skip to content

Commit

Permalink
Fix PlayStation build following 278635@main
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=274031

Unreviewed build fix.

278635@main introduced the first usage of `consteval` into the codebase;
apparently this works correctly in clang 9-10 and clang 15+, but not in clang 11-14.

Presumably we should introduce a macro in Compiler.h to allow us to use `consteval` where possible,
but for the moment, this patch just fixes the build by reverting `consteval` to `constexpr`.

* Source/WebCore/css/parser/CSSPropertyParserConsumer+RawTypes.h:
(WebCore::computeMinimumValue):

Canonical link: https://commits.webkit.org/278650@main
  • Loading branch information
rkirsling committed May 11, 2024
1 parent 42b0cd5 commit e4580b8
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ struct SymbolRaw {
NumberRaw replaceSymbol(SymbolRaw, const CSSCalcSymbolTable&);
template<typename T> T replaceSymbol(T value, const CSSCalcSymbolTable&) { return value; }

consteval double computeMinimumValue(CSSPropertyParserHelpers::IntegerValueRange range)
constexpr double computeMinimumValue(CSSPropertyParserHelpers::IntegerValueRange range)
{
switch (range) {
case CSSPropertyParserHelpers::IntegerValueRange::All:
Expand Down

0 comments on commit e4580b8

Please sign in to comment.