Skip to content

Commit

Permalink
Drop support for legacy EntityReference DOM Node type
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=149348

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline W3C DOM test now that more checks are passing.

* web-platform-tests/dom/historical-expected.txt:

Source/WebCore:

Drop support for legacy EntityReference DOM Node type.

EntityReference has been dropped from the DOM specification:
- https://dom.spec.whatwg.org/#dom-core-changes

EntityReference is not supported in Firefox:
- https://developer.mozilla.org/en-US/docs/Web/API/EntityReference
- https://developer.mozilla.org/en-US/docs/Web/API/NodeIterator.expandEntityReferences
- https://developer.mozilla.org/en-US/docs/Web/API/TreeWalker.expandEntityReferences

Chrome dropped support for EntityReference a while back (May 2013):
- EntityReference: https://code.google.com/p/chromium/issues/detail?id=226628
- NodeFilter / TreeWalker.expandEntityReferences:
  - https://groups.google.com/a/chromium.org/d/msg/blink-dev/-ZO3eja4maA/86T13XJwQpUJ
  - https://src.chromium.org/viewvc/blink?view=rev&revision=185771

IE also dropped support for EntityReference Nodes:
https://msdn.microsoft.com/library/ff974819(v=vs.85).aspx (Remarks section)

No new tests, already covered by existing test.

* DerivedSources.cpp:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/gobject/WebKitDOMPrivate.cpp:
(WebKit::wrap): Deleted.
* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline): Deleted.
* bindings/objc/DOM.mm:
(kitClass): Deleted.
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Skip webkit_dom_document_create_entity_reference until Carlos fixes it.
* dom/Attr.cpp:
(WebCore::Attr::childTypeAllowed):
(WebCore::Attr::childrenChanged): Deleted.
* dom/Attr.h:
* dom/ContainerNode.cpp:
(WebCore::checkAcceptChild): Deleted.
(WebCore::checkAcceptChildGuaranteedNodeTypes): Deleted.
(WebCore::ContainerNode::removeChild): Deleted.
* dom/Document.cpp:
(WebCore::Document::createEntityReference):
(WebCore::Document::createNodeIterator):
(WebCore::Document::createTreeWalker):
(WebCore::Document::createEditingTextNode): Deleted.
(WebCore::Document::importNode): Deleted.
(WebCore::Document::adoptNode): Deleted.
(WebCore::Document::scheduleForcedStyleRecalc): Deleted.
(WebCore::Document::scheduleStyleRecalc): Deleted.
(WebCore::Document::childTypeAllowed): Deleted.
(WebCore::Document::canAcceptChild): Deleted.
* dom/Document.h:
* dom/Document.idl:
* dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::childTypeAllowed): Deleted.
* dom/Element.cpp:
(WebCore::Element::childTypeAllowed): Deleted.
* dom/EntityReference.cpp:
(WebCore::EntityReference::EntityReference):
* dom/EntityReference.h:
* dom/EntityReference.idl:
* dom/Node.cpp:
(WebCore::Node::setNodeValue):
(WebCore::Node::dumpStatistics): Deleted.
(WebCore::Node::childNodes): Deleted.
(WebCore::Node::lastDescendant): Deleted.
(WebCore::Node::isDescendantOf): Deleted.
(WebCore::Node::textContent): Deleted.
(WebCore::Node::ancestorElement): Deleted.
(WebCore::hashPointer): Deleted.
* dom/Node.h:
(WebCore::Node::isDocumentTypeNode): Deleted.
* dom/NodeIterator.cpp:
(WebCore::NodeIterator::NodeIterator):
* dom/NodeIterator.h:
(WebCore::NodeIterator::create):
* dom/NodeIterator.idl:
* dom/Range.cpp:
(WebCore::Range::checkDeleteExtract):
(WebCore::lengthOfContentsInNode): Deleted.
(WebCore::Range::processContentsBetweenOffsets): Deleted.
(WebCore::Range::insertNode): Deleted.
(WebCore::Range::checkNodeWOffset): Deleted.
(WebCore::Range::checkNodeBA): Deleted.
(WebCore::Range::cloneRange): Deleted.
(WebCore::Range::selectNode): Deleted.
(WebCore::Range::selectNodeContents): Deleted.
(WebCore::Range::surroundContents): Deleted.
(WebCore::Range::shadowRoot): Deleted.
(WebCore::Range::pastLastNode): Deleted.
(WebCore::Range::absoluteBoundingBox): Deleted.
(WebCore::Range::absoluteTextRects): Deleted.
* dom/Range.h:
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::childTypeAllowed): Deleted.
* dom/Traversal.cpp:
(WebCore::NodeIteratorBase::NodeIteratorBase):
(WebCore::NodeIteratorBase::acceptNode): Deleted.
* dom/Traversal.h:
(WebCore::NodeIteratorBase::expandEntityReferences):
* dom/TreeWalker.cpp:
(WebCore::TreeWalker::TreeWalker):
* dom/TreeWalker.h:
(WebCore::TreeWalker::create):
* dom/TreeWalker.idl:
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendStartMarkup): Deleted.
* xml/XPathUtil.cpp:
(WebCore::XPath::isValidContextNode): Deleted.

Source/WebKit2:

Drop handling EntityReference Nodes.

* WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:
(WebKit::WKDOMNodeClass): Deleted.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::isAssistableElement):

LayoutTests:

Drop several outdated DOM compliance tests. Update / Rebaseline others.


Canonical link: https://commits.webkit.org/167550@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
cdumez committed Sep 22, 2015
1 parent 74c707c commit f1d879f
Show file tree
Hide file tree
Showing 209 changed files with 234 additions and 9,546 deletions.
9 changes: 9 additions & 0 deletions LayoutTests/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
2015-09-22 Chris Dumez <cdumez@apple.com>

Drop support for legacy EntityReference DOM Node type
https://bugs.webkit.org/show_bug.cgi?id=149348

Reviewed by Darin Adler.

Drop several outdated DOM compliance tests. Update / Rebaseline others.

2015-09-22 Chris Dumez <cdumez@apple.com>

Unreviewed, rebaseline several W3C html tests on iOS after r190106 and r190085.
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit f1d879f

Please sign in to comment.