-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Support mixed percentage and length/number arguments in CSS step func…
…tions https://bugs.webkit.org/show_bug.cgi?id=259714 rdar://problem/113234898 Reviewed by Tim Nguyen. We shouldn't just check that the two numeric argumnets to round() etc. have the same value category, but if one is Percent then we should support Length or Number as the other, and produce an overall LengthPercent or NumberPercent category. Fix another bug in this code, where we currently check that the numeric arguments aren't isRoundOperation(), but this should be isRoundConstant(). Otherwise values like round(round(10, 5), 2) are rejected. * LayoutTests/imported/w3c/web-platform-tests/css/css-values/round-mod-rem-computed-expected.txt: * Source/WebCore/css/calc/CSSCalcOperationNode.cpp: (WebCore::resolvedTypeForStep): (WebCore::CSSCalcOperationNode::createStep): (WebCore::CSSCalcOperationNode::createRound): (WebCore::validateRoundChildren): Deleted. Canonical link: https://commits.webkit.org/267072@main
- Loading branch information
Showing
2 changed files
with
51 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters