Fix availability annotations for _WKAttachment SPI

https://bugs.webkit.org/show_bug.cgi?id=184473 <rdar://problem/39319732> Reviewed by Dan Bernstein. _WKAttachmentInfo is available in WK_MAC_TBA and WK_IOS_TBA, but the SPI method -[_WKAttachment requestInfo:] is currently available in macOS 10.13.4 and iOS 11.3. Instead, the availability of this SPI should match the availability of the SPI object it depends on. * UIProcess/API/Cocoa/_WKAttachment.h: Canonical link: https://commits.webkit.org/200030@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit · Apr 11, 2018 · f86ae66 · f86ae66
1 parent efa4e10
commit f86ae66
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
@@ -1,3 +1,17 @@
+2018-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Fix availability annotations for _WKAttachment SPI
+        https://bugs.webkit.org/show_bug.cgi?id=184473
+        <rdar://problem/39319732>
+
+        Reviewed by Dan Bernstein.
+
+        _WKAttachmentInfo is available in WK_MAC_TBA and WK_IOS_TBA, but the SPI method -[_WKAttachment requestInfo:]
+        is currently available in macOS 10.13.4 and iOS 11.3. Instead, the availability of this SPI should match the
+        availability of the SPI object it depends on.
+
+        * UIProcess/API/Cocoa/_WKAttachment.h:
+
 2018-04-10  Chris Dumez  <cdumez@apple.com>
 
         Avoid constructing a service worker RegistrationStore for private sessions

diff --git a/Source/WebKit/UIProcess/API/Cocoa/_WKAttachment.h b/Source/WebKit/UIProcess/API/Cocoa/_WKAttachment.h
@@ -52,7 +52,7 @@ WK_CLASS_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA))
 
 WK_CLASS_AVAILABLE(macosx(10.13.4), ios(11.3))
 @interface _WKAttachment : NSObject
-- (void)requestInfo:(void(^)(_WKAttachmentInfo * _Nullable, NSError * _Nullable))completionHandler;
+- (void)requestInfo:(void(^)(_WKAttachmentInfo * _Nullable, NSError * _Nullable))completionHandler WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
 - (void)requestData:(void(^)(NSData * _Nullable, NSError * _Nullable))completionHandler;
 - (void)setDisplayOptions:(_WKAttachmentDisplayOptions *)options completion:(void(^ _Nullable)(NSError * _Nullable))completionHandler;
 - (void)setData:(NSData *)data newContentType:(nullable NSString *)newContentType newFilename:(nullable NSString *)newFilename completion:(void(^ _Nullable)(NSError * _Nullable))completionHandler;