-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[css-grid] Use transferred size over content size for automatic minim…
…um size https://bugs.webkit.org/show_bug.cgi?id=176688 Reviewed by Sergio Villar Senin. LayoutTests/imported/w3c: Import changes on the tests related to the new behavior. * web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-006.html: * web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-007.html: * web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-008.html: * web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-009.html: * web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html: * web-platform-tests/css/css-grid-1/grid-items/support/100x50-green.png: Removed. * web-platform-tests/css/css-grid-1/grid-items/support/25x50-green.png: Added. * web-platform-tests/css/css-grid-1/grid-items/support/50x100-green.png: Removed. * web-platform-tests/css/css-grid-1/grid-items/support/50x25-green.png: Added. * web-platform-tests/css/css-grid-1/grid-items/support/w3c-import.log: Source/WebCore: CSS WG has agreed to modify the spec so now the transferred size is used (if it exists) independently if it's bigger or smaller than the content size. See: w3c/csswg-drafts#1149 The spec text (https://drafts.csswg.org/css-grid/#min-size-auto): "The automatic minimum size for a grid item in a given dimension is its specified size if it exists, otherwise its transferred size if that exists, else its content size" This patch use the WPT tests updated to check the new behavior. * rendering/GridTrackSizingAlgorithm.cpp: (WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const): Modified so it always returns the transferred size (if any). Canonical link: https://commits.webkit.org/193251@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing
13 changed files
with
63 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file removed
BIN
-14.8 KB
...orted/w3c/web-platform-tests/css/css-grid-1/grid-items/support/100x50-green.png
Binary file not shown.
Binary file added
BIN
+99 Bytes
...ported/w3c/web-platform-tests/css/css-grid-1/grid-items/support/25x50-green.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-14.8 KB
...orted/w3c/web-platform-tests/css/css-grid-1/grid-items/support/50x100-green.png
Binary file not shown.
Binary file added
BIN
+100 Bytes
...ported/w3c/web-platform-tests/css/css-grid-1/grid-items/support/50x25-green.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters