Skip to content

Commit

Permalink
REGRESSION(272806@main): [Debug][GStreamer] ASSERTION FAILED: The str…
Browse files Browse the repository at this point in the history
…ing being removed is an atom in the string table of an other thread! in ~_WebKitVideoEncoderPrivate()

https://bugs.webkit.org/show_bug.cgi?id=267537

Reviewed by Philippe Normand.

Making an isolated copy of the passed codec string fixes the issue.

* Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp:
(videoEncoderSetEncoder):

Canonical link: https://commits.webkit.org/273048@main
  • Loading branch information
obyknovenius committed Jan 15, 2024
1 parent 7adc3dd commit fc613d1
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ static bool videoEncoderSetEncoder(WebKitVideoEncoder* self, EncoderId encoderId
}
}

priv->codecString = codecString;
priv->codecString = codecString.isolatedCopy();
encoderDefinition->setupEncoder(self);

encoderDefinition->setBitrateMode(priv->encoder.get(), priv->bitrateMode);
Expand Down

0 comments on commit fc613d1

Please sign in to comment.