Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Inspector: Add versioned protocol for iOS 16.4 and macOS 13.3 #10240

Conversation

patrickangle
Copy link
Contributor

@patrickangle patrickangle commented Feb 17, 2023

9d6e0de

Web Inspector: Add versioned protocol for iOS 16.4 and macOS 13.3
https://bugs.webkit.org/show_bug.cgi?id=252443
rdar://96976739

Reviewed by Devin Rousso.

Add legacy protocol definitions used while inspecting iOS 16.4 and macOS 13.3.

* Source/WebInspectorUI/UserInterface/Models/DOMNode.js:
(WI.DOMNode.prototype.showLayoutOverlay):
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/16.4/InspectorBackendCommands.js: Added.
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/13.3/InspectorBackendCommands.js: Added.
* Source/WebInspectorUI/Versions/Inspector-iOS-16.4.json: Added.
* Source/WebInspectorUI/Versions/Inspector-macOS-13.3.json: Added.

Canonical link: https://commits.webkit.org/260474@main

72d7143

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
🛠 🧪 merge ✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@patrickangle patrickangle self-assigned this Feb 17, 2023
@patrickangle patrickangle added the Web Inspector Bugs related to the WebKit Web Inspector. label Feb 17, 2023
@patrickangle patrickangle added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue labels Feb 17, 2023
https://bugs.webkit.org/show_bug.cgi?id=252443
rdar://96976739

Reviewed by Devin Rousso.

Add legacy protocol definitions used while inspecting iOS 16.4 and macOS 13.3.

* Source/WebInspectorUI/UserInterface/Models/DOMNode.js:
(WI.DOMNode.prototype.showLayoutOverlay):
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/iOS/16.4/InspectorBackendCommands.js: Added.
* Source/WebInspectorUI/UserInterface/Protocol/Legacy/macOS/13.3/InspectorBackendCommands.js: Added.
* Source/WebInspectorUI/Versions/Inspector-iOS-16.4.json: Added.
* Source/WebInspectorUI/Versions/Inspector-macOS-13.3.json: Added.

Canonical link: https://commits.webkit.org/260474@main
@webkit-commit-queue
Copy link
Collaborator

Committed 260474@main (9d6e0de): https://commits.webkit.org/260474@main

Reviewed commits have been landed. Closing PR #10240 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 9d6e0de into WebKit:main Feb 17, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web Inspector Bugs related to the WebKit Web Inspector.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants