Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION(256571@main): DrawingAreaCoordinatedGraphics should handle registering scrolling trees #10258

Merged
merged 1 commit into from
Feb 17, 2023
Merged

REGRESSION(256571@main): DrawingAreaCoordinatedGraphics should handle registering scrolling trees #10258

merged 1 commit into from
Feb 17, 2023

Conversation

zdobersek
Copy link
Contributor

@zdobersek zdobersek commented Feb 17, 2023 •
edited by webkit-early-warning-system

51a23ed

REGRESSION(256571@main): DrawingAreaCoordinatedGraphics should handle registering scrolling trees
https://bugs.webkit.org/show_bug.cgi?id=252462

Reviewed by Carlos Garcia Campos.

Override the registerScrollingTree and unregisterScrollingTree methods on the
DrawingAreaCoordinatedGraphics, (un)registering the scrolling tree on the
associated WebPage with the WebProcess-specific EventDispatcher instance. This
enables EventDispatcher to dispatch wheel events directly against the correct
ScrollingTree, instead of diverting them to the main thread when no such
ScrollingTree is found.

* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::registerScrollingTree):
(WebKit::DrawingAreaCoordinatedGraphics::unregisterScrollingTree):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h:

Canonical link: https://commits.webkit.org/260434@main

ec1fede

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe   🛠 wincairo
  🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
  🛠 tv   🧪 mac-wk2
  🛠 tv-sim   🧪 mac-AS-debug-wk2
  🛠 watch   🧪 mac-wk2-stress
  🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@zdobersek zdobersek self-assigned this Feb 17, 2023
@zdobersek zdobersek added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Feb 17, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash f3a3108)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ✅ 🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2 ⏳ 🛠 jsc-armv7
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2 ⏳ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

carlosgcampos
carlosgcampos approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@carlosgcampos carlosgcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This regressed in 256571@main, I already updated the bug title, please update the commit message too before landing. It's important to know in which branches it needs to be backported. Thanks!

@zdobersek zdobersek changed the title DrawingAreaCoordinatedGraphics should handle registering scrolling trees REGRESSION(256571@main): DrawingAreaCoordinatedGraphics should handle registering scrolling trees Feb 17, 2023
@zdobersek zdobersek force-pushed the eng/DrawingAreaCoordinatedGraphics-should-handle-registering-scrolling-trees branch from f3a3108 to ec1fede Compare February 17, 2023 09:30
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash ec1fede)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe   🛠 wincairo
  🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
  🛠 tv   🧪 mac-wk2
  🛠 tv-sim   🧪 mac-AS-debug-wk2
  🛠 watch   🧪 mac-wk2-stress
  🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@zdobersek zdobersek added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 17, 2023
@zdobersek
REGRESSION(256571@main): DrawingAreaCoordinatedGraphics should handle…
51a23ed 
… registering scrolling trees

https://bugs.webkit.org/show_bug.cgi?id=252462

Reviewed by Carlos Garcia Campos.

Override the registerScrollingTree and unregisterScrollingTree methods on the
DrawingAreaCoordinatedGraphics, (un)registering the scrolling tree on the
associated WebPage with the WebProcess-specific EventDispatcher instance. This
enables EventDispatcher to dispatch wheel events directly against the correct
ScrollingTree, instead of diverting them to the main thread when no such
ScrollingTree is found.

* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::registerScrollingTree):
(WebKit::DrawingAreaCoordinatedGraphics::unregisterScrollingTree):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h:

Canonical link: https://commits.webkit.org/260434@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/DrawingAreaCoordinatedGraphics-should-handle-registering-scrolling-trees branch from ec1fede to 51a23ed Compare February 17, 2023 09:35
@webkit-commit-queue
Copy link
Collaborator

Committed 260434@main (51a23ed): https://commits.webkit.org/260434@main

Reviewed commits have been landed. Closing PR #10258 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 51a23ed into WebKit:main Feb 17, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 17, 2023
@zdobersek zdobersek deleted the eng/DrawingAreaCoordinatedGraphics-should-handle-registering-scrolling-trees branch February 17, 2023 09:35
@aj062
Copy link
Member

aj062 commented Feb 17, 2023

This (260434@main) seems to break WinCairo build.

Failed: https://build.webkit.org/#/builders/731/builds/1904 with 260434@main
Passed: https://build.webkit.org/#/builders/731/builds/1903 with 260433@main

@aj062
Copy link
Member

aj062 commented Feb 17, 2023

C:\BW\WinCairo-64-bit-Release-Build\build\Source\WebKit\WebProcess\WebPage\CoordinatedGraphics\DrawingAreaCoordinatedGraphics.cpp(309): error C2039: 'addScrollingTreeForPage': is not a member of 'WebKit::EventDispatcher'
C:\BW\WinCairo-64-bit-Release-Build\build\Source\WebKit\WebProcess\WebPage\EventDispatcher.h(64): note: see declaration of 'WebKit::EventDispatcher'
C:\BW\WinCairo-64-bit-Release-Build\build\Source\WebKit\WebProcess\WebPage\CoordinatedGraphics\DrawingAreaCoordinatedGraphics.cpp(315): error C2039: 'removeScrollingTreeForPage': is not a member of 'WebKit::EventDispatcher'
C:\BW\WinCairo-64-bit-Release-Build\build\Source\WebKit\WebProcess\WebPage\EventDispatcher.h(64): note: see declaration of 'WebKit::EventDispatcher'

@zdobersek
Copy link
Contributor Author

Fixing

@zdobersek
Copy link
Contributor Author

In #10268.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosgcampos carlosgcampos carlosgcampos approved these changes

@magomez magomez Awaiting requested review from magomez magomez is a code owner

Assignees

@zdobersek zdobersek

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
5 participants
@zdobersek @webkit-early-warning-system @webkit-commit-queue @aj062 @carlosgcampos