Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION(256571@main): DrawingAreaCoordinatedGraphics should handle registering scrolling trees #10268

Merged
merged 1 commit into from
Feb 17, 2023
Merged

REGRESSION(256571@main): DrawingAreaCoordinatedGraphics should handle registering scrolling trees #10268

merged 1 commit into from
Feb 17, 2023

Conversation

zdobersek
Copy link
Contributor

@zdobersek zdobersek commented Feb 17, 2023 •
edited by webkit-early-warning-system

9789cde

REGRESSION(256571@main): DrawingAreaCoordinatedGraphics should handle registering scrolling trees
https://bugs.webkit.org/show_bug.cgi?id=252462

Reviewed by Carlos Garcia Campos.

Override the registerScrollingTree and unregisterScrollingTree methods on the
DrawingAreaCoordinatedGraphics, (un)registering the scrolling tree on the
associated WebPage with the WebProcess-specific EventDispatcher instance. This
enables EventDispatcher to dispatch wheel events directly against the correct
ScrollingTree, instead of diverting them to the main thread when no such
ScrollingTree is found.

* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::registerScrollingTree):
(WebKit::DrawingAreaCoordinatedGraphics::unregisterScrollingTree):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h:

Canonical link: https://commits.webkit.org/260454@main

9f6049a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
  🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@zdobersek zdobersek self-assigned this Feb 17, 2023
@zdobersek zdobersek added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Feb 17, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 9f6049a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
  🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@zdobersek zdobersek mentioned this pull request Feb 17, 2023
Merged
@zdobersek zdobersek added the merge-queue Applied to send a pull request to merge-queue label Feb 17, 2023
@zdobersek
REGRESSION(256571@main): DrawingAreaCoordinatedGraphics should handle…
9789cde 
… registering scrolling trees

https://bugs.webkit.org/show_bug.cgi?id=252462

Reviewed by Carlos Garcia Campos.

Override the registerScrollingTree and unregisterScrollingTree methods on the
DrawingAreaCoordinatedGraphics, (un)registering the scrolling tree on the
associated WebPage with the WebProcess-specific EventDispatcher instance. This
enables EventDispatcher to dispatch wheel events directly against the correct
ScrollingTree, instead of diverting them to the main thread when no such
ScrollingTree is found.

* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::registerScrollingTree):
(WebKit::DrawingAreaCoordinatedGraphics::unregisterScrollingTree):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h:

Canonical link: https://commits.webkit.org/260454@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/REGRESSION256571main-DrawingAreaCoordinatedGraphics-should-handle-registering-scrolling-trees branch from 9f6049a to 9789cde Compare February 17, 2023 18:35
@webkit-commit-queue
Copy link
Collaborator

Committed 260454@main (9789cde): https://commits.webkit.org/260454@main

Reviewed commits have been landed. Closing PR #10268 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 9789cde into WebKit:main Feb 17, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosgcampos carlosgcampos carlosgcampos approved these changes

@magomez magomez Awaiting requested review from magomez magomez is a code owner

Assignees

@zdobersek zdobersek

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
4 participants
@zdobersek @webkit-early-warning-system @webkit-commit-queue @carlosgcampos