[GStreamer][WebRTC] Disabled incoming audio track breaks webaudio provider #10520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philn
added
the
Platform
|
EWS run on previous version of this PR (hash 7e6cd54)
|
calvaris
approved these changes
Feb 23, 2023
Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp
Outdated
Show resolved
Hide resolved
|
EWS run on current version of this PR (hash 1778c76)
|
…vider https://bugs.webkit.org/show_bug.cgi?id=252751 Reviewed by Xabier Rodriguez-Calvar. Disabling an incoming audio track internally means that the mediastreamsrc switches from RTP payloads to raw audio. The AudioSourceProvider wasn't able to reliably handle this, but switching its internal pipeline to uridecodebin3 solves the issue. Internally uridecodebin3 will be able to reconfigure properly. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp: (WebCore::AudioSourceProviderGStreamer::AudioSourceProviderGStreamer): (WebCore::AudioSourceProviderGStreamer::~AudioSourceProviderGStreamer): (WebCore::AudioSourceProviderGStreamer::setClient): * Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h: Canonical link: https://commits.webkit.org/260742@main
webkit-early-warning-system
force-pushed
the
eng/252751
branch
from
1778c76
to
5e1b941
Compare
|
Committed 260742@main (5e1b941): https://commits.webkit.org/260742@main Reviewed commits have been landed. Closing PR #10520 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5e1b941
1778c76
🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🧪 mac-wk2🧪 mac-AS-debug-wk2