Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GStreamer][WebRTC] Disabled incoming audio track breaks webaudio provider #10520

Merged
merged 1 commit into from
Feb 23, 2023
Merged

[GStreamer][WebRTC] Disabled incoming audio track breaks webaudio provider #10520

merged 1 commit into from
Feb 23, 2023

Commits on Feb 23, 2023

  1. [GStreamer][WebRTC] Disabled incoming audio track breaks webaudio pro… 

    …vider

https://bugs.webkit.org/show_bug.cgi?id=252751

Reviewed by Xabier Rodriguez-Calvar.

Disabling an incoming audio track internally means that the mediastreamsrc switches from RTP
payloads to raw audio. The AudioSourceProvider wasn't able to reliably handle this, but switching
its internal pipeline to uridecodebin3 solves the issue. Internally uridecodebin3 will be able to
reconfigure properly.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:
(WebCore::AudioSourceProviderGStreamer::AudioSourceProviderGStreamer):
(WebCore::AudioSourceProviderGStreamer::~AudioSourceProviderGStreamer):
(WebCore::AudioSourceProviderGStreamer::setClient):
* Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h:

Canonical link: https://commits.webkit.org/260742@main
    @philn
    philn committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    5e1b941 View commit details
    Browse the repository at this point in the history