[JSC] Add lock / unlock mechanism to LRU in new wasm BBQ for scratch #10624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
JavaScriptCore
Constellation
force-pushed
the
eng/JSC-Add-lock--unlock-mechanism-to-LRU-in-new-wasm-BBQ-for-scratch
branch
4 times, most recently
from
670996b
to
60c03f0
Compare
|
Locally test it as built. Landing (since this is new BBQ, not enabled and not tested yet). |
|
EWS run on previous version of this PR (hash 8d757cc) |
|
EWS run on previous version of this PR (hash 4917257) |
|
EWS run on previous version of this PR (hash 0e34172) |
Constellation
added
the
unsafe-merge-queue
|
EWS run on current version of this PR (hash 670996b) |
|
EWS run on previous version of this PR (hash 60c03f0)
|
https://bugs.webkit.org/show_bug.cgi?id=252869 rdar://105856151 Reviewed by Justin Michaud. When a register is used for scratch, then we must not evict it while it is used since (1) we would like to have a register, and (2) there is no way to save and restore scratches. However we have no mechanism to prevent it, and we crash when running tfjs-wasm in JetStream3. This patch integrates lock and unlock mechanism for registers allocated for scratches. This lock / unlock names are derived from DFG's reigster allocator & Baseline JIT's IC register allocators. We mark scratches as locked, and they are not used for register allocation targets. We would like to expand this mechanism for the non scratch registers when it is currently used and we would like to lock it down right now. But in this patch, let's first do it for scratches. * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJIT::LRU::findMin): (JSC::Wasm::BBQJIT::LRU::lock): (JSC::Wasm::BBQJIT::LRU::unlock): (JSC::Wasm::BBQJIT::ScratchScope::gpr const): (JSC::Wasm::BBQJIT::ScratchScope::fpr const): (JSC::Wasm::BBQJIT::ScratchScope::bindGPRToScratch): (JSC::Wasm::BBQJIT::ScratchScope::bindFPRToScratch): (JSC::Wasm::BBQJIT::ScratchScope::unbindGPRFromScratch): (JSC::Wasm::BBQJIT::ScratchScope::unbindFPRFromScratch): Canonical link: https://commits.webkit.org/260771@main
webkit-early-warning-system
force-pushed
the
eng/JSC-Add-lock--unlock-mechanism-to-LRU-in-new-wasm-BBQ-for-scratch
branch
from
60c03f0
to
ffae772
Compare
|
Committed 260771@main (ffae772): https://commits.webkit.org/260771@main Reviewed commits have been landed. Closing PR #10624 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ffae772
670996b
🧪 style🛠 ios🛠 gtk🧪 webkitperl🧪 gtk-wk2🧪 api-gtk