Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GBM] Update RemoteGraphicsContextGLProxyGBM construction #10639

Conversation

zdobersek
Copy link
Contributor

@zdobersek zdobersek commented Feb 24, 2023

171c5e7

[GBM] Update RemoteGraphicsContextGLProxyGBM construction
https://bugs.webkit.org/show_bug.cgi?id=252890

Reviewed by Carlos Garcia Campos.

Update the RemoteGraphicsContextGLProxyGBM constructor and its invocation,
aligning it to the new RemoteGraphicsContextGLProxy::platformCreate() method
and RemoteGraphicsContextGLProxy constructor signature.

* Source/WebKit/WebProcess/GPU/graphics/gbm/RemoteGraphicsContextGLProxyGBM.cpp:
(WebKit::RemoteGraphicsContextGLProxyGBM::RemoteGraphicsContextGLProxyGBM):
(WebKit::RemoteGraphicsContextGLProxy::platformCreate):
(WebKit::RemoteGraphicsContextGLProxy::create): Deleted.

Canonical link: https://commits.webkit.org/260789@main

7927884

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
🧪 api-ios ✅ 🧪 mac-wk1 ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@zdobersek zdobersek self-assigned this Feb 24, 2023
@zdobersek zdobersek added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Feb 24, 2023
@zdobersek zdobersek added the merge-queue Applied to send a pull request to merge-queue label Feb 24, 2023
https://bugs.webkit.org/show_bug.cgi?id=252890

Reviewed by Carlos Garcia Campos.

Update the RemoteGraphicsContextGLProxyGBM constructor and its invocation,
aligning it to the new RemoteGraphicsContextGLProxy::platformCreate() method
and RemoteGraphicsContextGLProxy constructor signature.

* Source/WebKit/WebProcess/GPU/graphics/gbm/RemoteGraphicsContextGLProxyGBM.cpp:
(WebKit::RemoteGraphicsContextGLProxyGBM::RemoteGraphicsContextGLProxyGBM):
(WebKit::RemoteGraphicsContextGLProxy::platformCreate):
(WebKit::RemoteGraphicsContextGLProxy::create): Deleted.

Canonical link: https://commits.webkit.org/260789@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/GBM-Update-RemoteGraphicsContextGLProxyGBM-construction branch from 7927884 to 171c5e7 Compare February 24, 2023 11:54
@webkit-commit-queue
Copy link
Collaborator

Committed 260789@main (171c5e7): https://commits.webkit.org/260789@main

Reviewed commits have been landed. Closing PR #10639 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 171c5e7 into WebKit:main Feb 24, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 24, 2023
@zdobersek zdobersek deleted the eng/GBM-Update-RemoteGraphicsContextGLProxyGBM-construction branch February 24, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants