[GPU Process] Cache Gradient as a rendering resource #11252

shallawa · 2023-03-08T21:31:45Z

`676af9d`

[GPU Process] Cache Gradient as a rendering resource
https://bugs.webkit.org/show_bug.cgi?id=253599
rdar://106447608

Reviewed by Cameron McCormack.

Sending the gradient data to GPUProcess every time it is used forces creating
the platform gradient.

To avoid creating the platform gradient, we are going to cache Gradient as a
rendering resource in GPUProcess. So the object (and its platform gradient) will
stay alive in GPUProcess as long as the WebProcess gradient is alive.

* Source/WebCore/platform/graphics/DecomposedGlyphs.cpp:
(WebCore::DecomposedGlyphs::create):
(): Deleted.
* Source/WebCore/platform/graphics/DecomposedGlyphs.h:
* Source/WebCore/platform/graphics/Gradient.cpp:
(WebCore::Gradient::create):
(WebCore::Gradient::Gradient):
(WebCore::operator<<):
* Source/WebCore/platform/graphics/Gradient.h:
(WebCore::Gradient::create):
(WebCore::Gradient::colorInterpolationMethod const):
(WebCore::Gradient::spreadMethod const):
(WebCore::Gradient::stops const):
* Source/WebCore/platform/graphics/GraphicsContextState.h:
(WebCore::GraphicsContextState::fillBrush):
(WebCore::GraphicsContextState::strokeBrush):
* Source/WebCore/platform/graphics/NativeImage.h:
* Source/WebCore/platform/graphics/RenderingResource.h:
(WebCore::RenderingResource::~RenderingResource):
(WebCore::RenderingResource::hasValidRenderingResourceIdentifier const):
(WebCore::RenderingResource::renderingResourceIdentifier const):
(WebCore::RenderingResource::addObserver):
(WebCore::RenderingResource::removeObserver):
(WebCore::RenderingResource::RenderingResource):
* Source/WebCore/platform/graphics/SourceBrush.cpp:
(WebCore::SourceBrush::gradientSpaceTransform const):
(WebCore::SourceBrush::gradient const):
(WebCore::SourceBrush::gradientIdentifier const):
(WebCore::SourceBrush::setGradient):
* Source/WebCore/platform/graphics/SourceBrush.h:
(WebCore::SourceBrush::setGradient):
(WebCore::operator==):
(WebCore::SourceBrush::Brush::LogicalGradient::encode const):
(WebCore::SourceBrush::Brush::LogicalGradient::decode):
* Source/WebCore/platform/graphics/displaylists/DisplayList.h:
(WebCore::DisplayList::DisplayList::cacheDecomposedGlyphs):
(WebCore::DisplayList::DisplayList::cacheGradient):
* Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:
(WebCore::DisplayList::SetState::state):
* Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::appendStateChangeItem):
* Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h:
* Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp:
(WebCore::DisplayList::RecorderImpl::recordResourceUse):
* Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h:
* Source/WebCore/platform/graphics/displaylists/DisplayListResourceHeap.h:
(WebCore::DisplayList::LocalResourceHeap::add):
* Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.cpp:
(WebCore::RenderSVGResourceLinearGradient::buildGradient const):
* Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.cpp:
(WebCore::RenderSVGResourceRadialGradient::buildGradient const):
* Source/WebKit/GPUProcess/graphics/QualifiedResourceHeap.h:
(WebKit::QualifiedResourceHeap::add):
(WebKit::QualifiedResourceHeap::getGradient const):
(WebKit::QualifiedResourceHeap::removeGradient):
(WebKit::QualifiedResourceHeap::releaseAllResources):
(WebKit::QualifiedResourceHeap::checkInvariants const):
* Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp:
(WebKit::RemoteDisplayListRecorder::setState):
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::cacheGradient):
(WebKit::RemoteRenderingBackend::cacheGradientWithQualifiedIdentifier):
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in:
* Source/WebKit/GPUProcess/graphics/RemoteResourceCache.cpp:
(WebKit::RemoteResourceCache::cacheGradient):
(WebKit::RemoteResourceCache::cachedGradient const):
(WebKit::RemoteResourceCache::releaseRenderingResource):
* Source/WebKit/GPUProcess/graphics/RemoteResourceCache.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
(WebKit::RemoteDisplayListRecorderProxy::recordResourceUse):
* Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::cacheGradient):
* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
* Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:
(WebKit::RemoteResourceCacheProxy::~RemoteResourceCacheProxy):
(WebKit::RemoteResourceCacheProxy::clear):
(WebKit::RemoteResourceCacheProxy::recordGradientUse):
(WebKit::RemoteResourceCacheProxy::releaseRenderingResource):
(WebKit::RemoteResourceCacheProxy::clearGradientMap):
(WebKit::RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed):
(WebKit::RemoteResourceCacheProxy::releaseMemory):
* Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:

Canonical link: https://commits.webkit.org/262185@main

78a0467

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-wk2	⏳ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-03-08T21:32:16Z

EWS run on previous version of this PR (hash 2b39fb0)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	~~🛠 gtk~~
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	~~🧪 api-gtk~~
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-03-10T00:46:24Z

EWS run on previous version of this PR (hash dac1862)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-03-16T22:27:15Z

EWS run on previous version of this PR (hash 9f44c23)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-wk2	⏳ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-03-24T00:44:26Z

EWS run on current version of this PR (hash 78a0467)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-wk2	⏳ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch-sim

heycam · 2023-03-24T21:44:07Z

Source/WebCore/platform/graphics/RenderingResource.h

+    bool hasValidRenderingResourceIdentifier() const
+    {
+        return m_renderingResourceIdentifier.has_value();
+    }


When do we create resources without a valid RenderingResourceIdentifier? Is it that we don't provide an identifier for gradients that are cheap to send across or something? If so, instead of doing it based on whether the identifier is valid, is it something the encode/decode functions can decide by inspecting the gradient? Then we can continue to have valid identifiers always.

When trying to cache all gradients, I noticed MotionMark CanvasLines regressed significantly. The reason for this is CanvasLines creates a gradient every time a line is drawn https://github.com/WebKit/WebKit/blob/main/PerformanceTests/MotionMark/tests/master/resources/canvas-tests.js#L238. So caching this gradient was not beneficial at all since each gradient is just used only once. This contrary to SVG gradients which lives as long as the SVG object lives. So only SVG gradients will have valid RenderingResourceIdentifier.

https://bugs.webkit.org/show_bug.cgi?id=253599 rdar://106447608 Reviewed by Cameron McCormack. Sending the gradient data to GPUProcess every time it is used forces creating the platform gradient. To avoid creating the platform gradient, we are going to cache Gradient as a rendering resource in GPUProcess. So the object (and its platform gradient) will stay alive in GPUProcess as long as the WebProcess gradient is alive. * Source/WebCore/platform/graphics/DecomposedGlyphs.cpp: (WebCore::DecomposedGlyphs::create): (): Deleted. * Source/WebCore/platform/graphics/DecomposedGlyphs.h: * Source/WebCore/platform/graphics/Gradient.cpp: (WebCore::Gradient::create): (WebCore::Gradient::Gradient): (WebCore::operator<<): * Source/WebCore/platform/graphics/Gradient.h: (WebCore::Gradient::create): (WebCore::Gradient::colorInterpolationMethod const): (WebCore::Gradient::spreadMethod const): (WebCore::Gradient::stops const): * Source/WebCore/platform/graphics/GraphicsContextState.h: (WebCore::GraphicsContextState::fillBrush): (WebCore::GraphicsContextState::strokeBrush): * Source/WebCore/platform/graphics/NativeImage.h: * Source/WebCore/platform/graphics/RenderingResource.h: (WebCore::RenderingResource::~RenderingResource): (WebCore::RenderingResource::hasValidRenderingResourceIdentifier const): (WebCore::RenderingResource::renderingResourceIdentifier const): (WebCore::RenderingResource::addObserver): (WebCore::RenderingResource::removeObserver): (WebCore::RenderingResource::RenderingResource): * Source/WebCore/platform/graphics/SourceBrush.cpp: (WebCore::SourceBrush::gradientSpaceTransform const): (WebCore::SourceBrush::gradient const): (WebCore::SourceBrush::gradientIdentifier const): (WebCore::SourceBrush::setGradient): * Source/WebCore/platform/graphics/SourceBrush.h: (WebCore::SourceBrush::setGradient): (WebCore::operator==): (WebCore::SourceBrush::Brush::LogicalGradient::encode const): (WebCore::SourceBrush::Brush::LogicalGradient::decode): * Source/WebCore/platform/graphics/displaylists/DisplayList.h: (WebCore::DisplayList::DisplayList::cacheDecomposedGlyphs): (WebCore::DisplayList::DisplayList::cacheGradient): * Source/WebCore/platform/graphics/displaylists/DisplayListItems.h: (WebCore::DisplayList::SetState::state): * Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp: (WebCore::DisplayList::Recorder::appendStateChangeItem): * Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h: * Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp: (WebCore::DisplayList::RecorderImpl::recordResourceUse): * Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h: * Source/WebCore/platform/graphics/displaylists/DisplayListResourceHeap.h: (WebCore::DisplayList::LocalResourceHeap::add): * Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.cpp: (WebCore::RenderSVGResourceLinearGradient::buildGradient const): * Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.cpp: (WebCore::RenderSVGResourceRadialGradient::buildGradient const): * Source/WebKit/GPUProcess/graphics/QualifiedResourceHeap.h: (WebKit::QualifiedResourceHeap::add): (WebKit::QualifiedResourceHeap::getGradient const): (WebKit::QualifiedResourceHeap::removeGradient): (WebKit::QualifiedResourceHeap::releaseAllResources): (WebKit::QualifiedResourceHeap::checkInvariants const): * Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp: (WebKit::RemoteDisplayListRecorder::setState): * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::cacheGradient): (WebKit::RemoteRenderingBackend::cacheGradientWithQualifiedIdentifier): * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h: * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in: * Source/WebKit/GPUProcess/graphics/RemoteResourceCache.cpp: (WebKit::RemoteResourceCache::cacheGradient): (WebKit::RemoteResourceCache::cachedGradient const): (WebKit::RemoteResourceCache::releaseRenderingResource): * Source/WebKit/GPUProcess/graphics/RemoteResourceCache.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp: (WebKit::RemoteDisplayListRecorderProxy::recordResourceUse): * Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h: * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp: (WebKit::RemoteRenderingBackendProxy::cacheGradient): * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h: * Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp: (WebKit::RemoteResourceCacheProxy::~RemoteResourceCacheProxy): (WebKit::RemoteResourceCacheProxy::clear): (WebKit::RemoteResourceCacheProxy::recordGradientUse): (WebKit::RemoteResourceCacheProxy::releaseRenderingResource): (WebKit::RemoteResourceCacheProxy::clearGradientMap): (WebKit::RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed): (WebKit::RemoteResourceCacheProxy::releaseMemory): * Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.h: Canonical link: https://commits.webkit.org/262185@main

webkit-commit-queue · 2023-03-28T00:14:28Z

Committed 262185@main (676af9d): https://commits.webkit.org/262185@main

Reviewed commits have been landed. Closing PR #11252 and removing active labels.

philn · 2023-03-28T10:58:43Z

Thiis broke linux clang builds...

In file included from /app/webkit/WebKitBuild/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-35.cpp:1:                                                                                        
In file included from /app/webkit/Source/WebCore/platform/graphics/RenderingMode.cpp:29:                                                                                                                             
In file included from /app/webkit/WebKitBuild/Release/WTF/Headers/wtf/text/TextStream.h:29:                                                                                                                          
In file included from /app/webkit/WebKitBuild/Release/WTF/Headers/wtf/Markable.h:39:                                                                                                                                 
In file included from /app/webkit/WebKitBuild/Release/WTF/Headers/wtf/Hasher.h:27:                                                                                                                                   
In file included from /app/webkit/WebKitBuild/Release/WTF/Headers/wtf/URL.h:28:                                                                                                                                      
In file included from /app/webkit/WebKitBuild/Release/WTF/Headers/wtf/text/WTFString.h:28:                                                                                                                           
In file included from /app/webkit/WebKitBuild/Release/WTF/Headers/wtf/text/StringImpl.h:29:                                                                                                                          
In file included from /app/webkit/WebKitBuild/Release/WTF/Headers/wtf/CompactPtr.h:32:                                                                                                                               
In file included from /app/webkit/WebKitBuild/Release/WTF/Headers/wtf/HashFunctions.h:26:                                                                                                                            
In file included from /app/webkit/WebKitBuild/Release/WTF/Headers/wtf/RefPtr.h:28:                                                                                                                                   
/app/webkit/WebKitBuild/Release/WTF/Headers/wtf/Ref.h:90:11: error: cannot initialize a member subobject of type 'typename PtrTraits::StorageType' (aka 'WebCore::Gradient *') with an rvalue of type 'WebCore::Patte
rn *'                                                                                                                                                                                                                
        : m_ptr(&other.leakRef())                                                                                                                                                                                    
          ^     ~~~~~~~~~~~~~~~~                                                                                                                                                                                     
/usr/lib/gcc/x86_64-unknown-linux-gnu/12.2.0/../../../../include/c++/12.2.0/variant:284:6: note: in instantiation of function template specialization 'WTF::Ref<WebCore::Gradient>::Ref<WebCore::Pattern, WTF::RawPtr
Traits<WebCore::Pattern>>' requested here                                                                                                                                                                            
     _Type(std::forward<_Args>(__args)...);                                                                                                                                                                          
     ^                                                                                                                                                                                                               
1 error generated.

Would it be possible to simplify the struct Brush layout to avoid embedding variants in variants please? The current setup seems ambiguous, somehow...

shallawa · 2023-03-28T17:27:55Z

Would it be possible to simplify the struct Brush layout to avoid embedding variants in variants please? The current setup seems ambiguous, somehow...

struct Brush can be either a LogicalGradient or Ref<Pattern>. This is what GraphicsContextState wants to fill or stroke with.

If it is a LogicalGradient it will have either a Ref<Gradient> or RenderingResourceIdentifier besides the spaceTransform. Representing the LogicalGradient with RenderingResourceIdentifier is used while encoding the Brush.

So why do think this structure is not simplified and seems ambiguous?

I could not understand from the lines above which line in the code causes this error. Can you please include more lines from the compilation output?

philn · 2023-03-28T18:12:44Z

That's the beauty of it, thanks to unified builds, the error message is almost useless. What I shared is what's reported by the tooling, I don't have more details...

@zdobersek mentioned in-place constructors might help

shallawa · 2023-03-29T17:20:30Z

That's the beauty of it, thanks to unified builds, the error message is almost useless. What I shared is what's reported by the tooling, I don't have more details...

I think there is a build option to disable local unified builds. @JonWBedard might know more about this option.

zdobersek · 2023-03-30T15:27:01Z

Fixed in #12177.

shallawa requested a review from cdumez as a code owner March 8, 2023 21:31

shallawa self-assigned this Mar 8, 2023

shallawa added the Layout and Rendering For bugs with layout and rendering of Web pages. label Mar 8, 2023

shallawa force-pushed the eng/GPU-Process-Cache-Gradient-as-a-rendering-resource branch from 2b39fb0 to dac1862 Compare March 9, 2023 23:48

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 10, 2023

shallawa removed the merging-blocked Applied to prevent a change from being merged label Mar 16, 2023

shallawa force-pushed the eng/GPU-Process-Cache-Gradient-as-a-rendering-resource branch from dac1862 to 9f44c23 Compare March 16, 2023 22:25

shallawa requested review from smfr and heycam March 20, 2023 17:42

shallawa force-pushed the eng/GPU-Process-Cache-Gradient-as-a-rendering-resource branch from 9f44c23 to 78a0467 Compare March 24, 2023 00:43

heycam approved these changes Mar 24, 2023

View reviewed changes

shallawa added the merge-queue Applied to send a pull request to merge-queue label Mar 27, 2023

webkit-commit-queue force-pushed the eng/GPU-Process-Cache-Gradient-as-a-rendering-resource branch from 78a0467 to 676af9d Compare March 28, 2023 00:14

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 28, 2023

webkit-commit-queue merged commit 676af9d into WebKit:main Mar 28, 2023

shallawa deleted the eng/GPU-Process-Cache-Gradient-as-a-rendering-resource branch May 9, 2023 20:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GPU Process] Cache Gradient as a rendering resource #11252

[GPU Process] Cache Gradient as a rendering resource #11252

shallawa commented Mar 8, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Mar 8, 2023 •

edited

webkit-early-warning-system commented Mar 10, 2023 •

edited

webkit-early-warning-system commented Mar 16, 2023 •

edited

webkit-early-warning-system commented Mar 24, 2023 •

edited

heycam Mar 24, 2023

shallawa Mar 27, 2023

webkit-commit-queue commented Mar 28, 2023

philn commented Mar 28, 2023

shallawa commented Mar 28, 2023

philn commented Mar 28, 2023

shallawa commented Mar 29, 2023

zdobersek commented Mar 30, 2023

[GPU Process] Cache Gradient as a rendering resource #11252

[GPU Process] Cache Gradient as a rendering resource #11252

Conversation

shallawa commented Mar 8, 2023 • edited by webkit-early-warning-system

676af9d

webkit-early-warning-system commented Mar 8, 2023 • edited

webkit-early-warning-system commented Mar 10, 2023 • edited

webkit-early-warning-system commented Mar 16, 2023 • edited

webkit-early-warning-system commented Mar 24, 2023 • edited

heycam Mar 24, 2023

Choose a reason for hiding this comment

shallawa Mar 27, 2023

Choose a reason for hiding this comment

webkit-commit-queue commented Mar 28, 2023

philn commented Mar 28, 2023

shallawa commented Mar 28, 2023

philn commented Mar 28, 2023

shallawa commented Mar 29, 2023

zdobersek commented Mar 30, 2023

shallawa commented Mar 8, 2023 •

edited by webkit-early-warning-system

`676af9d`

webkit-early-warning-system commented Mar 8, 2023 •

edited

webkit-early-warning-system commented Mar 10, 2023 •

edited

webkit-early-warning-system commented Mar 16, 2023 •

edited

webkit-early-warning-system commented Mar 24, 2023 •

edited