Commits on Mar 28, 2023

1. [GPU Process] Cache Gradient as a rendering resource …

   https://bugs.webkit.org/show_bug.cgi?id=253599
   rdar://106447608
   
   Reviewed by Cameron McCormack.
   
   Sending the gradient data to GPUProcess every time it is used forces creating
   the platform gradient.
   
   To avoid creating the platform gradient, we are going to cache Gradient as a
   rendering resource in GPUProcess. So the object (and its platform gradient) will
   stay alive in GPUProcess as long as the WebProcess gradient is alive.
   
   * Source/WebCore/platform/graphics/DecomposedGlyphs.cpp:
   (WebCore::DecomposedGlyphs::create):
   (): Deleted.
   * Source/WebCore/platform/graphics/DecomposedGlyphs.h:
   * Source/WebCore/platform/graphics/Gradient.cpp:
   (WebCore::Gradient::create):
   (WebCore::Gradient::Gradient):
   (WebCore::operator<<):
   * Source/WebCore/platform/graphics/Gradient.h:
   (WebCore::Gradient::create):
   (WebCore::Gradient::colorInterpolationMethod const):
   (WebCore::Gradient::spreadMethod const):
   (WebCore::Gradient::stops const):
   * Source/WebCore/platform/graphics/GraphicsContextState.h:
   (WebCore::GraphicsContextState::fillBrush):
   (WebCore::GraphicsContextState::strokeBrush):
   * Source/WebCore/platform/graphics/NativeImage.h:
   * Source/WebCore/platform/graphics/RenderingResource.h:
   (WebCore::RenderingResource::~RenderingResource):
   (WebCore::RenderingResource::hasValidRenderingResourceIdentifier const):
   (WebCore::RenderingResource::renderingResourceIdentifier const):
   (WebCore::RenderingResource::addObserver):
   (WebCore::RenderingResource::removeObserver):
   (WebCore::RenderingResource::RenderingResource):
   * Source/WebCore/platform/graphics/SourceBrush.cpp:
   (WebCore::SourceBrush::gradientSpaceTransform const):
   (WebCore::SourceBrush::gradient const):
   (WebCore::SourceBrush::gradientIdentifier const):
   (WebCore::SourceBrush::setGradient):
   * Source/WebCore/platform/graphics/SourceBrush.h:
   (WebCore::SourceBrush::setGradient):
   (WebCore::operator==):
   (WebCore::SourceBrush::Brush::LogicalGradient::encode const):
   (WebCore::SourceBrush::Brush::LogicalGradient::decode):
   * Source/WebCore/platform/graphics/displaylists/DisplayList.h:
   (WebCore::DisplayList::DisplayList::cacheDecomposedGlyphs):
   (WebCore::DisplayList::DisplayList::cacheGradient):
   * Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:
   (WebCore::DisplayList::SetState::state):
   * Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:
   (WebCore::DisplayList::Recorder::appendStateChangeItem):
   * Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h:
   * Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp:
   (WebCore::DisplayList::RecorderImpl::recordResourceUse):
   * Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h:
   * Source/WebCore/platform/graphics/displaylists/DisplayListResourceHeap.h:
   (WebCore::DisplayList::LocalResourceHeap::add):
   * Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.cpp:
   (WebCore::RenderSVGResourceLinearGradient::buildGradient const):
   * Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.cpp:
   (WebCore::RenderSVGResourceRadialGradient::buildGradient const):
   * Source/WebKit/GPUProcess/graphics/QualifiedResourceHeap.h:
   (WebKit::QualifiedResourceHeap::add):
   (WebKit::QualifiedResourceHeap::getGradient const):
   (WebKit::QualifiedResourceHeap::removeGradient):
   (WebKit::QualifiedResourceHeap::releaseAllResources):
   (WebKit::QualifiedResourceHeap::checkInvariants const):
   * Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp:
   (WebKit::RemoteDisplayListRecorder::setState):
   * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:
   (WebKit::RemoteRenderingBackend::cacheGradient):
   (WebKit::RemoteRenderingBackend::cacheGradientWithQualifiedIdentifier):
   * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:
   * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in:
   * Source/WebKit/GPUProcess/graphics/RemoteResourceCache.cpp:
   (WebKit::RemoteResourceCache::cacheGradient):
   (WebKit::RemoteResourceCache::cachedGradient const):
   (WebKit::RemoteResourceCache::releaseRenderingResource):
   * Source/WebKit/GPUProcess/graphics/RemoteResourceCache.h:
   * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
   * Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
   (WebKit::RemoteDisplayListRecorderProxy::recordResourceUse):
   * Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:
   * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
   (WebKit::RemoteRenderingBackendProxy::cacheGradient):
   * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
   * Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:
   (WebKit::RemoteResourceCacheProxy::~RemoteResourceCacheProxy):
   (WebKit::RemoteResourceCacheProxy::clear):
   (WebKit::RemoteResourceCacheProxy::recordGradientUse):
   (WebKit::RemoteResourceCacheProxy::releaseRenderingResource):
   (WebKit::RemoteResourceCacheProxy::clearGradientMap):
   (WebKit::RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed):
   (WebKit::RemoteResourceCacheProxy::releaseMemory):
   * Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:
   
   Canonical link: https://commits.webkit.org/262185@main

   

   shallawa authored and Said Abou-Hallawa committed Mar 28, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 676af9d
   • Browse repository at this point

   Copy the full SHA

   676af9d View commit details

   Browse the repository at this point in the history