REGRESSION(261586@main): The assertion is randomly failing #11499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdumez
added
New Bugs
|
EWS run on current version of this PR (hash a9bbf4a)
|
https://bugs.webkit.org/show_bug.cgi?id=253875 rdar://106705387 Unreviewed, drop assertion in ~Document() to make sure that m_ranges is empty as it is hitting on the bots since we updated m_ranges to be a WeakHashSet. Ranges no longer remove themselves in their destructor from this set so this assertion is no longer guaranteed to hold. The WeakHashSet will empty itself as Range objects get destroyed but ~Document() may get called while the destructor of a Range is still running. * Source/WebCore/dom/Document.cpp: (WebCore::Document::~Document): Canonical link: https://commits.webkit.org/261634@main
webkit-commit-queue
force-pushed
the
eng/REGRESSION261586main-The-assertion-is-randomly-failing
branch
from
a9bbf4a
to
91848d6
Compare
|
Committed 261634@main (91848d6): https://commits.webkit.org/261634@main Reviewed commits have been landed. Closing PR #11499 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
91848d6
a9bbf4a
🛠 wpe🛠 wincairo🧪 bindings🛠 mac-AS-debug🧪 wpe-wk2🧪 webkitperl🧪 ios-wk2🧪 api-mac🧪 api-ios🧪 mac-wk1🧪 gtk-wk2🛠 tv🧪 mac-wk2🧪 api-gtk🛠 tv-sim🧪 mac-AS-debug-wk2🛠 watch🧪 mac-wk2-stress🛠 watch-sim